Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2032003002: Minor cleanup in IncomingVideoStream. (Closed)

Created:
4 years, 6 months ago by mflodman
Modified:
4 years, 6 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused render callback method+pointer in IncomingVideoStream. Committed: https://crrev.com/5724b7317ee9ceaae2b131fda645c72ed29e282d Cr-Commit-Position: refs/heads/master@{#13009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M webrtc/common_video/include/incoming_video_stream.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/common_video/incoming_video_stream.cc View 4 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mflodman
Tommi, Please take a look.
4 years, 6 months ago (2016-06-02 08:14:56 UTC) #2
tommi
lgtm Nice. Lgtm. Can you update th
4 years, 6 months ago (2016-06-02 09:14:15 UTC) #3
tommi
On 2016/06/02 09:14:15, tommi-webrtc wrote: > lgtm > > Nice. Lgtm. > Can you update ...
4 years, 6 months ago (2016-06-02 09:16:15 UTC) #4
mflodman
Done.
4 years, 6 months ago (2016-06-02 09:27:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032003002/1
4 years, 6 months ago (2016-06-02 09:27:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 09:39:08 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:39:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5724b7317ee9ceaae2b131fda645c72ed29e282d
Cr-Commit-Position: refs/heads/master@{#13009}

Powered by Google App Engine
This is Rietveld 408576698