Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Side by Side Diff: webrtc/common_video/incoming_video_stream.cc

Issue 2032003002: Minor cleanup in IncomingVideoStream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/common_video/include/incoming_video_stream.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/common_video/include/incoming_video_stream.h" 11 #include "webrtc/common_video/include/incoming_video_stream.h"
12 12
13 #include <assert.h> 13 #include <assert.h>
14 14
15 #if defined(_WIN32)
16 #include <windows.h>
17 #elif defined(WEBRTC_LINUX)
18 #include <sys/time.h>
19 #include <time.h>
20 #else
21 #include <sys/time.h>
22 #endif
23
24 #include "webrtc/base/platform_thread.h" 15 #include "webrtc/base/platform_thread.h"
25 #include "webrtc/base/timeutils.h" 16 #include "webrtc/base/timeutils.h"
26 #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h"
27 #include "webrtc/common_video/video_render_frames.h" 17 #include "webrtc/common_video/video_render_frames.h"
28 #include "webrtc/system_wrappers/include/critical_section_wrapper.h" 18 #include "webrtc/system_wrappers/include/critical_section_wrapper.h"
29 #include "webrtc/system_wrappers/include/event_wrapper.h" 19 #include "webrtc/system_wrappers/include/event_wrapper.h"
30 #include "webrtc/system_wrappers/include/trace.h"
31 20
32 namespace webrtc { 21 namespace webrtc {
33 22
34 IncomingVideoStream::IncomingVideoStream(bool disable_prerenderer_smoothing) 23 IncomingVideoStream::IncomingVideoStream(bool disable_prerenderer_smoothing)
35 : disable_prerenderer_smoothing_(disable_prerenderer_smoothing), 24 : disable_prerenderer_smoothing_(disable_prerenderer_smoothing),
36 incoming_render_thread_(), 25 incoming_render_thread_(),
37 deliver_buffer_event_(EventTimerWrapper::Create()), 26 deliver_buffer_event_(EventTimerWrapper::Create()),
38 running_(false), 27 running_(false),
39 external_callback_(nullptr), 28 external_callback_(nullptr),
40 render_callback_(nullptr),
41 render_buffers_(new VideoRenderFrames()), 29 render_buffers_(new VideoRenderFrames()),
42 incoming_rate_(0), 30 incoming_rate_(0),
43 last_rate_calculation_time_ms_(0), 31 last_rate_calculation_time_ms_(0),
44 num_frames_since_last_calculation_(0) {} 32 num_frames_since_last_calculation_(0) {}
45 33
46 IncomingVideoStream::~IncomingVideoStream() { 34 IncomingVideoStream::~IncomingVideoStream() {
47 Stop(); 35 Stop();
48 } 36 }
49 37
50 void IncomingVideoStream::OnFrame(const VideoFrame& video_frame) { 38 void IncomingVideoStream::OnFrame(const VideoFrame& video_frame) {
(...skipping 18 matching lines...) Expand all
69 if (disable_prerenderer_smoothing_) { 57 if (disable_prerenderer_smoothing_) {
70 DeliverFrame(video_frame); 58 DeliverFrame(video_frame);
71 } else { 59 } else {
72 rtc::CritScope csB(&buffer_critsect_); 60 rtc::CritScope csB(&buffer_critsect_);
73 if (render_buffers_->AddFrame(video_frame) == 1) { 61 if (render_buffers_->AddFrame(video_frame) == 1) {
74 deliver_buffer_event_->Set(); 62 deliver_buffer_event_->Set();
75 } 63 }
76 } 64 }
77 } 65 }
78 66
79 void IncomingVideoStream::SetRenderCallback(
80 rtc::VideoSinkInterface<VideoFrame>* render_callback) {
81 rtc::CritScope cs(&thread_critsect_);
82 render_callback_ = render_callback;
83 }
84
85 int32_t IncomingVideoStream::SetExpectedRenderDelay( 67 int32_t IncomingVideoStream::SetExpectedRenderDelay(
86 int32_t delay_ms) { 68 int32_t delay_ms) {
87 rtc::CritScope csS(&stream_critsect_); 69 rtc::CritScope csS(&stream_critsect_);
88 if (running_) { 70 if (running_) {
89 return -1; 71 return -1;
90 } 72 }
91 rtc::CritScope cs(&buffer_critsect_); 73 rtc::CritScope cs(&buffer_critsect_);
92 return render_buffers_->SetRenderDelay(delay_ms); 74 return render_buffers_->SetRenderDelay(delay_ms);
93 } 75 }
94 76
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 void IncomingVideoStream::DeliverFrame(const VideoFrame& video_frame) { 179 void IncomingVideoStream::DeliverFrame(const VideoFrame& video_frame) {
198 rtc::CritScope cs(&thread_critsect_); 180 rtc::CritScope cs(&thread_critsect_);
199 if (video_frame.IsZeroSize()) { 181 if (video_frame.IsZeroSize()) {
200 // No frame. 182 // No frame.
201 return; 183 return;
202 } 184 }
203 185
204 // Send frame for rendering. 186 // Send frame for rendering.
205 if (external_callback_) { 187 if (external_callback_) {
206 external_callback_->OnFrame(video_frame); 188 external_callback_->OnFrame(video_frame);
207 } else if (render_callback_) {
208 render_callback_->OnFrame(video_frame);
209 } 189 }
210 } 190 }
211 191
212 } // namespace webrtc 192 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/common_video/include/incoming_video_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698