Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2030333003: Revert of Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls. (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
Wez
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls. (patchset #7 id:140001 of https://codereview.webrtc.org/1988783003/ ) Reason for revert: Broke chromium builder Original issue's description: > Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls. > > Previously raw pointers were used for owned DesktopFrame instances. > Updated all screen and window capturer implementations to use > std::unique_ptr<>. > > Also includes some other cleanups in the capturers: > - s/NULL/nullptr > - moved default initializers to class definition. > > BUG=webrtc:5950 > > Committed: https://crrev.com/4a627a8c13554d12412cabb8f751caee6e61ee32 > Cr-Commit-Position: refs/heads/master@{#13032} TBR=wez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5950 Committed: https://crrev.com/b4c7b8365d9ed11099b4c5bdcc4eeab33923cd9c Cr-Commit-Position: refs/heads/master@{#13033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -401 lines) Patch
M webrtc/modules/desktop_capture/cropped_desktop_frame.h View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/desktop_capture/cropped_desktop_frame.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc View 3 chunks +13 lines, -17 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc View 3 chunks +10 lines, -14 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capturer.h View 1 chunk +5 lines, -26 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capture_frame_queue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 19 chunks +66 lines, -49 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac_unittest.cc View 2 chunks +12 lines, -17 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mock_objects.h View 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_unittest.cc View 6 chunks +14 lines, -16 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 10 chunks +50 lines, -36 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.h View 2 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.cc View 2 chunks +40 lines, -15 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.cc View 9 chunks +35 lines, -33 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.cc View 9 chunks +31 lines, -23 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h View 2 chunks +16 lines, -16 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc View 8 chunks +48 lines, -17 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_mac.mm View 9 chunks +20 lines, -17 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_null.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_win.cc View 6 chunks +20 lines, -16 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_x11.cc View 8 chunks +25 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sergey Ulanov
Created Revert of Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls.
4 years, 6 months ago (2016-06-03 12:56:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030333003/1
4 years, 6 months ago (2016-06-03 12:56:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 12:56:47 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 12:56:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4c7b8365d9ed11099b4c5bdcc4eeab33923cd9c
Cr-Commit-Position: refs/heads/master@{#13033}

Powered by Google App Engine
This is Rietveld 408576698