Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: webrtc/modules/desktop_capture/window_capturer_null.cc

Issue 2030333003: Revert of Use std::unique_ptr<> to pass frame ownership in DesktopCapturer impls. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 // WindowCapturer interface. 27 // WindowCapturer interface.
28 bool GetWindowList(WindowList* windows) override; 28 bool GetWindowList(WindowList* windows) override;
29 bool SelectWindow(WindowId id) override; 29 bool SelectWindow(WindowId id) override;
30 bool BringSelectedWindowToFront() override; 30 bool BringSelectedWindowToFront() override;
31 31
32 // DesktopCapturer interface. 32 // DesktopCapturer interface.
33 void Start(Callback* callback) override; 33 void Start(Callback* callback) override;
34 void Capture(const DesktopRegion& region) override; 34 void Capture(const DesktopRegion& region) override;
35 35
36 private: 36 private:
37 Callback* callback_ = nullptr; 37 Callback* callback_;
38 38
39 RTC_DISALLOW_COPY_AND_ASSIGN(WindowCapturerNull); 39 RTC_DISALLOW_COPY_AND_ASSIGN(WindowCapturerNull);
40 }; 40 };
41 41
42 WindowCapturerNull::WindowCapturerNull() {} 42 WindowCapturerNull::WindowCapturerNull()
43 WindowCapturerNull::~WindowCapturerNull() {} 43 : callback_(NULL) {
44 }
45
46 WindowCapturerNull::~WindowCapturerNull() {
47 }
44 48
45 bool WindowCapturerNull::GetWindowList(WindowList* windows) { 49 bool WindowCapturerNull::GetWindowList(WindowList* windows) {
46 // Not implemented yet. 50 // Not implemented yet.
47 return false; 51 return false;
48 } 52 }
49 53
50 bool WindowCapturerNull::SelectWindow(WindowId id) { 54 bool WindowCapturerNull::SelectWindow(WindowId id) {
51 // Not implemented yet. 55 // Not implemented yet.
52 return false; 56 return false;
53 } 57 }
54 58
55 bool WindowCapturerNull::BringSelectedWindowToFront() { 59 bool WindowCapturerNull::BringSelectedWindowToFront() {
56 // Not implemented yet. 60 // Not implemented yet.
57 return false; 61 return false;
58 } 62 }
59 63
60 void WindowCapturerNull::Start(Callback* callback) { 64 void WindowCapturerNull::Start(Callback* callback) {
61 assert(!callback_); 65 assert(!callback_);
62 assert(callback); 66 assert(callback);
63 67
64 callback_ = callback; 68 callback_ = callback;
65 } 69 }
66 70
67 void WindowCapturerNull::Capture(const DesktopRegion& region) { 71 void WindowCapturerNull::Capture(const DesktopRegion& region) {
68 // Not implemented yet. 72 // Not implemented yet.
69 callback_->OnCaptureResult(Result::ERROR_TEMPORARY, nullptr); 73 callback_->OnCaptureCompleted(NULL);
70 } 74 }
71 75
72 } // namespace 76 } // namespace
73 77
74 // static 78 // static
75 WindowCapturer* WindowCapturer::Create(const DesktopCaptureOptions& options) { 79 WindowCapturer* WindowCapturer::Create(const DesktopCaptureOptions& options) {
76 return new WindowCapturerNull(); 80 return new WindowCapturerNull();
77 } 81 }
78 82
79 } // namespace webrtc 83 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/desktop_capture/window_capturer_mac.mm ('k') | webrtc/modules/desktop_capture/window_capturer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698