NetEq: Ask AudioDecoder for sample rate instead of passing it as an argument

webrtc/modules/audio_coding/neteq/decoder_database.h

Index: webrtc/modules/audio_coding/neteq/decoder_database.h
diff --git a/webrtc/modules/audio_coding/neteq/decoder_database.h b/webrtc/modules/audio_coding/neteq/decoder_database.h
index 4169dc2b1b7d96f9ed2295c4ce546e8623ebb7fe..404f2575b29627a0ba9fe319d2d7c60e31a5bbb3 100644
--- a/webrtc/modules/audio_coding/neteq/decoder_database.h
+++ b/webrtc/modules/audio_coding/neteq/decoder_database.h
@@ -44,7 +44,6 @@ class DecoderDatabase {
     DecoderInfo(NetEqDecoder ct, const std::string& nm);
     DecoderInfo(NetEqDecoder ct,
                 const std::string& nm,
-                int sample_rate_hz,
                 AudioDecoder* ext_dec);
     DecoderInfo(DecoderInfo&&);
     ~DecoderInfo();
@@ -57,10 +56,10 @@ class DecoderDatabase {
     void DropDecoder() { decoder_.reset(); }
 
     int SampleRateHz() const {
-      RTC_DCHECK_EQ(1, !!decoder_ + !!external_decoder + !!cng_decoder_);
+      RTC_DCHECK_EQ(1, !!decoder_ + !!external_decoder_ + !!cng_decoder_);
       return decoder_ ? decoder_->SampleRateHz()
-                      : external_decoder ? external_decoder->sample_rate_hz
-                                         : cng_decoder_->sample_rate_hz;
+                      : external_decoder_ ? external_decoder_->SampleRateHz()
+                                          : cng_decoder_->sample_rate_hz;
     }
 
     const NetEqDecoder codec_type;
@@ -71,13 +70,7 @@ class DecoderDatabase {
     std::unique_ptr<AudioDecoder> decoder_;
 
     // Set iff this is an external decoder.
-    struct ExternalDecoder {
-      // TODO(kwiberg): Remove sample_rate_hz once we can trust all decoders to
-      // implement SampleRateHz().
-      int sample_rate_hz;
-      AudioDecoder* decoder;
-    };
-    const rtc::Optional<ExternalDecoder> external_decoder;

[hlundin-webrtc, 2016/06/01 13:49:21]

What?! No trailing underscore on the member variable? Who reviewed this?

[kwiberg-webrtc, 2016/06/01 13:55:33]

It appears to have been written and reviewed by two utter nincompoops. Luckily
for them, there's no way to find out who they were after all this time.

https://codereview.webrtc.org/2021063002

+    AudioDecoder* const external_decoder_;
 
     // Set iff this is a comfort noise decoder.
     struct CngDecoder {
@@ -120,7 +113,6 @@ class DecoderDatabase {
   virtual int InsertExternal(uint8_t rtp_payload_type,
                              NetEqDecoder codec_type,
                              const std::string& codec_name,
-                             int fs_hz,
                              AudioDecoder* decoder);
 
   // Removes the entry for |rtp_payload_type| from the database.