Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2026403003: Fix a memory issue when calling LOG_J in port.cc (Closed)

Created:
4 years, 6 months ago by honghaiz3
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a memory issue when calling LOG_J in port.cc The connection delete message may be processed when a port is being deleted. Calling LOG_J here needs to access the port object that may have been partially released. This fixes the memcheck bot failure. TBR=pthatcher@webrtc.org BUG= Committed: https://crrev.com/18f9da02865294f8d34527e290ad85697dfceb3b Cr-Commit-Position: refs/heads/master@{#13002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/p2p/base/port.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026403003/1
4 years, 6 months ago (2016-06-02 06:01:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026403003/1
4 years, 6 months ago (2016-06-02 06:02:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 06:53:06 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:53:14 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18f9da02865294f8d34527e290ad85697dfceb3b
Cr-Commit-Position: refs/heads/master@{#13002}

Powered by Google App Engine
This is Rietveld 408576698