Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: webrtc/p2p/base/port.cc

Issue 2026403003: Fix a memory issue when calling LOG_J in port.cc (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1386 matching lines...) Expand 10 before | Expand all | Expand 10 after
1397 remote_candidate_.address() == new_candidate.address() && 1397 remote_candidate_.address() == new_candidate.address() &&
1398 remote_candidate_.username() == new_candidate.username() && 1398 remote_candidate_.username() == new_candidate.username() &&
1399 remote_candidate_.password() == new_candidate.password() && 1399 remote_candidate_.password() == new_candidate.password() &&
1400 remote_candidate_.generation() == new_candidate.generation()) { 1400 remote_candidate_.generation() == new_candidate.generation()) {
1401 remote_candidate_ = new_candidate; 1401 remote_candidate_ = new_candidate;
1402 } 1402 }
1403 } 1403 }
1404 1404
1405 void Connection::OnMessage(rtc::Message *pmsg) { 1405 void Connection::OnMessage(rtc::Message *pmsg) {
1406 ASSERT(pmsg->message_id == MSG_DELETE); 1406 ASSERT(pmsg->message_id == MSG_DELETE);
1407 LOG_J(LS_INFO, this) << "Connection deleted with number of pings sent: " 1407 LOG(LS_INFO) << "Connection deleted with number of pings sent: "
1408 << num_pings_sent_; 1408 << num_pings_sent_;
1409 SignalDestroyed(this); 1409 SignalDestroyed(this);
1410 delete this; 1410 delete this;
1411 } 1411 }
1412 1412
1413 int64_t Connection::last_received() const { 1413 int64_t Connection::last_received() const {
1414 return std::max(last_data_received_, 1414 return std::max(last_data_received_,
1415 std::max(last_ping_received_, last_ping_response_received_)); 1415 std::max(last_ping_received_, last_ping_response_received_));
1416 } 1416 }
1417 1417
1418 ConnectionInfo Connection::stats() { 1418 ConnectionInfo Connection::stats() {
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
1508 ASSERT(sent < 0); 1508 ASSERT(sent < 0);
1509 error_ = port_->GetError(); 1509 error_ = port_->GetError();
1510 stats_.sent_discarded_packets++; 1510 stats_.sent_discarded_packets++;
1511 } else { 1511 } else {
1512 send_rate_tracker_.AddSamples(sent); 1512 send_rate_tracker_.AddSamples(sent);
1513 } 1513 }
1514 return sent; 1514 return sent;
1515 } 1515 }
1516 1516
1517 } // namespace cricket 1517 } // namespace cricket
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698