Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1231)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

Issue 2025843002: [rtcp] ExtendedJitterReports::Parse updated not to use RTCPUtility (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: typo Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
index 34eb57f34847984421af457683df9f6724874274..7731988df47f151c0fc73ba3333ed4227659d6c2 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h
@@ -13,33 +13,26 @@
#include <vector>
-#include "webrtc/base/checks.h"
#include "webrtc/base/constructormagic.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h"
-#include "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"
namespace webrtc {
namespace rtcp {
+class CommonHeader;
class ExtendedJitterReport : public RtcpPacket {
public:
- static const uint8_t kPacketType = 195;
+ static constexpr uint8_t kPacketType = 195;
- ExtendedJitterReport() : RtcpPacket() {}
-
- virtual ~ExtendedJitterReport() {}
+ ExtendedJitterReport() {}
+ ~ExtendedJitterReport() override {}
// Parse assumes header is already parsed and validated.
- bool Parse(const RTCPUtility::RtcpCommonHeader& header,
- const uint8_t* payload); // Size of the payload is in the header.
+ bool Parse(const CommonHeader& packet);
bool WithJitter(uint32_t jitter);
- size_t jitters_count() const { return inter_arrival_jitters_.size(); }
- uint32_t jitter(size_t index) const {
- RTC_DCHECK_LT(index, jitters_count());
- return inter_arrival_jitters_[index];
- }
+ const std::vector<uint32_t>& jitters() { return inter_arrival_jitters_; }
protected:
bool Create(uint8_t* packet,
@@ -48,10 +41,11 @@ class ExtendedJitterReport : public RtcpPacket {
RtcpPacket::PacketReadyCallback* callback) const override;
private:
- static const int kMaxNumberOfJitters = 0x1f;
+ static constexpr size_t kMaxNumberOfJitters = 0x1f;
+ static constexpr size_t kJitterSizeBytes = 4;
size_t BlockLength() const override {
- return kHeaderLength + 4 * inter_arrival_jitters_.size();
+ return kHeaderLength + kJitterSizeBytes * inter_arrival_jitters_.size();
}
std::vector<uint32_t> inter_arrival_jitters_;
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698