Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h

Issue 2025843002: [rtcp] ExtendedJitterReports::Parse updated not to use RTCPUtility (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: typo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
13 13
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/base/checks.h"
17 #include "webrtc/base/constructormagic.h" 16 #include "webrtc/base/constructormagic.h"
18 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h" 17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet.h"
19 #include "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"
20 18
21 namespace webrtc { 19 namespace webrtc {
22 namespace rtcp { 20 namespace rtcp {
21 class CommonHeader;
23 22
24 class ExtendedJitterReport : public RtcpPacket { 23 class ExtendedJitterReport : public RtcpPacket {
25 public: 24 public:
26 static const uint8_t kPacketType = 195; 25 static constexpr uint8_t kPacketType = 195;
27 26
28 ExtendedJitterReport() : RtcpPacket() {} 27 ExtendedJitterReport() {}
29 28 ~ExtendedJitterReport() override {}
30 virtual ~ExtendedJitterReport() {}
31 29
32 // Parse assumes header is already parsed and validated. 30 // Parse assumes header is already parsed and validated.
33 bool Parse(const RTCPUtility::RtcpCommonHeader& header, 31 bool Parse(const CommonHeader& packet);
34 const uint8_t* payload); // Size of the payload is in the header.
35 32
36 bool WithJitter(uint32_t jitter); 33 bool WithJitter(uint32_t jitter);
37 34
38 size_t jitters_count() const { return inter_arrival_jitters_.size(); } 35 const std::vector<uint32_t>& jitters() { return inter_arrival_jitters_; }
39 uint32_t jitter(size_t index) const {
40 RTC_DCHECK_LT(index, jitters_count());
41 return inter_arrival_jitters_[index];
42 }
43 36
44 protected: 37 protected:
45 bool Create(uint8_t* packet, 38 bool Create(uint8_t* packet,
46 size_t* index, 39 size_t* index,
47 size_t max_length, 40 size_t max_length,
48 RtcpPacket::PacketReadyCallback* callback) const override; 41 RtcpPacket::PacketReadyCallback* callback) const override;
49 42
50 private: 43 private:
51 static const int kMaxNumberOfJitters = 0x1f; 44 static constexpr size_t kMaxNumberOfJitters = 0x1f;
45 static constexpr size_t kJitterSizeBytes = 4;
52 46
53 size_t BlockLength() const override { 47 size_t BlockLength() const override {
54 return kHeaderLength + 4 * inter_arrival_jitters_.size(); 48 return kHeaderLength + kJitterSizeBytes * inter_arrival_jitters_.size();
55 } 49 }
56 50
57 std::vector<uint32_t> inter_arrival_jitters_; 51 std::vector<uint32_t> inter_arrival_jitters_;
58 52
59 RTC_DISALLOW_COPY_AND_ASSIGN(ExtendedJitterReport); 53 RTC_DISALLOW_COPY_AND_ASSIGN(ExtendedJitterReport);
60 }; 54 };
61 55
62 } // namespace rtcp 56 } // namespace rtcp
63 } // namespace webrtc 57 } // namespace webrtc
64 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_ 58 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_EXTENDED_JITTER_REPORT_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698