Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2025843002: [rtcp] ExtendedJitterReports::Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] ExtendedJitterReports::Parse updated not to use RTCPUtility BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/b684bd10bef1093f8992f2ff0d78d93325dca6d2 Cr-Commit-Position: refs/heads/master@{#13016}

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -83 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h View 2 chunks +9 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.cc View 3 chunks +11 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc View 1 2 chunks +35 lines, -53 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
åsapersson
lgtm https://codereview.webrtc.org/2025843002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc (right): https://codereview.webrtc.org/2025843002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc#newcode73 webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc:73: raw[0]++; // Damange packet: increase jitter count by ...
4 years, 6 months ago (2016-06-02 10:09:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025843002/20001
4 years, 6 months ago (2016-06-02 10:35:18 UTC) #4
danilchap
https://codereview.webrtc.org/2025843002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc (right): https://codereview.webrtc.org/2025843002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc#newcode73 webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc:73: raw[0]++; // Damange packet: increase jitter count by 1. ...
4 years, 6 months ago (2016-06-02 11:03:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 12:06:58 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 12:07:09 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b684bd10bef1093f8992f2ff0d78d93325dca6d2
Cr-Commit-Position: refs/heads/master@{#13016}

Powered by Google App Engine
This is Rietveld 408576698