Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2023803002: [rtcp] Fir/Sli/Rpsi updated not to use RTCPUtility (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] Fir/Sli/Rpsi updated not to use RTCPUtility BUG=webrtc:5260 Committed: https://crrev.com/0fc37d7dec48d5c66c583035b1090d466cc4a8a2 Cr-Commit-Position: refs/heads/master@{#12965}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -165 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h View 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/fir_unittest.cc View 4 chunks +25 lines, -51 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi_unittest.cc View 10 chunks +14 lines, -27 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sli.h View 3 chunks +5 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sli.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sli_unittest.cc View 3 chunks +21 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
åsapersson
lgtm
4 years, 6 months ago (2016-05-30 13:03:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023803002/20001
4 years, 6 months ago (2016-05-30 13:09:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-05-30 15:10:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023803002/20001
4 years, 6 months ago (2016-05-31 08:26:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-05-31 08:36:42 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 08:36:54 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0fc37d7dec48d5c66c583035b1090d466cc4a8a2
Cr-Commit-Position: refs/heads/master@{#12965}

Powered by Google App Engine
This is Rietveld 408576698