Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.h

Issue 2023803002: [rtcp] Fir/Sli/Rpsi updated not to use RTCPUtility (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_FIR_H_ 11 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_FIR_H_
12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_FIR_H_ 12 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_FIR_H_
13 13
14 #include <vector> 14 #include <vector>
15 15
16 #include "webrtc/base/basictypes.h" 16 #include "webrtc/base/basictypes.h"
17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h" 17 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h"
18 #include "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"
19 18
20 namespace webrtc { 19 namespace webrtc {
21 namespace rtcp { 20 namespace rtcp {
21 class CommonHeader;
22 // Full intra request (FIR) (RFC 5104). 22 // Full intra request (FIR) (RFC 5104).
23 class Fir : public Psfb { 23 class Fir : public Psfb {
24 public: 24 public:
25 static const uint8_t kFeedbackMessageType = 4; 25 static constexpr uint8_t kFeedbackMessageType = 4;
26 struct Request { 26 struct Request {
27 Request() : ssrc(0), seq_nr(0) {} 27 Request() : ssrc(0), seq_nr(0) {}
28 Request(uint32_t ssrc, uint8_t seq_nr) : ssrc(ssrc), seq_nr(seq_nr) {} 28 Request(uint32_t ssrc, uint8_t seq_nr) : ssrc(ssrc), seq_nr(seq_nr) {}
29 uint32_t ssrc; 29 uint32_t ssrc;
30 uint8_t seq_nr; 30 uint8_t seq_nr;
31 }; 31 };
32 32
33 Fir() {} 33 Fir() {}
34 ~Fir() override {} 34 ~Fir() override {}
35 35
36 // Parse assumes header is already parsed and validated. 36 // Parse assumes header is already parsed and validated.
37 bool Parse(const RTCPUtility::RtcpCommonHeader& header, 37 bool Parse(const CommonHeader& packet);
38 const uint8_t* payload); // Size of the payload is in the header.
39 38
40 void WithRequestTo(uint32_t ssrc, uint8_t seq_num) { 39 void WithRequestTo(uint32_t ssrc, uint8_t seq_num) {
41 items_.push_back(Request(ssrc, seq_num)); 40 items_.push_back(Request(ssrc, seq_num));
42 } 41 }
43 const std::vector<Request>& requests() const { return items_; } 42 const std::vector<Request>& requests() const { return items_; }
44 43
45 protected: 44 protected:
46 bool Create(uint8_t* packet, 45 bool Create(uint8_t* packet,
47 size_t* index, 46 size_t* index,
48 size_t max_length, 47 size_t max_length,
49 RtcpPacket::PacketReadyCallback* callback) const override; 48 RtcpPacket::PacketReadyCallback* callback) const override;
50 49
51 private: 50 private:
52 static const size_t kFciLength = 8; 51 static constexpr size_t kFciLength = 8;
53 size_t BlockLength() const override { 52 size_t BlockLength() const override {
54 return kHeaderLength + kCommonFeedbackLength + kFciLength * items_.size(); 53 return kHeaderLength + kCommonFeedbackLength + kFciLength * items_.size();
55 } 54 }
56 // SSRC of media source is not used in FIR packet. Shadow base functions. 55 // SSRC of media source is not used in FIR packet. Shadow base functions.
57 void To(uint32_t ssrc); 56 void To(uint32_t ssrc);
58 uint32_t media_ssrc() const; 57 uint32_t media_ssrc() const;
59 58
60 std::vector<Request> items_; 59 std::vector<Request> items_;
61 }; 60 };
62 } // namespace rtcp 61 } // namespace rtcp
63 } // namespace webrtc 62 } // namespace webrtc
64 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_FIR_H_ 63 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_FIR_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/fir.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698