Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: webrtc/api/rtpreceiver.h

Issue 2023373002: Separating internal and external methods of RtpSender/RtpReceiver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Renaming "ProxyTo<X>" to "ProxyWithInternal<X>" Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/proxy_unittest.cc ('k') | webrtc/api/rtpreceiver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtpreceiver.h
diff --git a/webrtc/api/rtpreceiver.h b/webrtc/api/rtpreceiver.h
index 2e7339d4da448c60888fc0cba6f0bbfc1affd752..001264d7a761181f76380a6fc1b27e09569f9f60 100644
--- a/webrtc/api/rtpreceiver.h
+++ b/webrtc/api/rtpreceiver.h
@@ -26,9 +26,15 @@
namespace webrtc {
+// Internal class used by PeerConnection.
+class RtpReceiverInternal : public RtpReceiverInterface {
+ public:
+ virtual void Stop() = 0;
+};
+
class AudioRtpReceiver : public ObserverInterface,
public AudioSourceInterface::AudioObserver,
- public rtc::RefCountedObject<RtpReceiverInterface> {
+ public rtc::RefCountedObject<RtpReceiverInternal> {
public:
AudioRtpReceiver(MediaStreamInterface* stream,
const std::string& track_id,
@@ -54,11 +60,12 @@ class AudioRtpReceiver : public ObserverInterface,
std::string id() const override { return id_; }
- void Stop() override;
-
RtpParameters GetParameters() const override;
bool SetParameters(const RtpParameters& parameters) override;
+ // RtpReceiverInternal implementation.
+ void Stop() override;
+
private:
void Reconfigure();
@@ -69,7 +76,7 @@ class AudioRtpReceiver : public ObserverInterface,
bool cached_track_enabled_;
};
-class VideoRtpReceiver : public rtc::RefCountedObject<RtpReceiverInterface> {
+class VideoRtpReceiver : public rtc::RefCountedObject<RtpReceiverInternal> {
public:
VideoRtpReceiver(MediaStreamInterface* stream,
const std::string& track_id,
@@ -90,11 +97,12 @@ class VideoRtpReceiver : public rtc::RefCountedObject<RtpReceiverInterface> {
std::string id() const override { return id_; }
- void Stop() override;
-
RtpParameters GetParameters() const override;
bool SetParameters(const RtpParameters& parameters) override;
+ // RtpReceiverInternal implementation.
+ void Stop() override;
+
private:
std::string id_;
uint32_t ssrc_;
« no previous file with comments | « webrtc/api/proxy_unittest.cc ('k') | webrtc/api/rtpreceiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698