Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: webrtc/api/rtpreceiver.cc

Issue 2023373002: Separating internal and external methods of RtpSender/RtpReceiver. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Renaming "ProxyTo<X>" to "ProxyWithInternal<X>" Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/rtpreceiver.h ('k') | webrtc/api/rtpreceiverinterface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtpreceiver.cc
diff --git a/webrtc/api/rtpreceiver.cc b/webrtc/api/rtpreceiver.cc
index 1b52ce27def13f255c245d353aa239f4d64d1078..9df336e1f042ca79afb2814905af52c2840a7753 100644
--- a/webrtc/api/rtpreceiver.cc
+++ b/webrtc/api/rtpreceiver.cc
@@ -58,15 +58,6 @@ void AudioRtpReceiver::OnSetVolume(double volume) {
provider_->SetAudioPlayoutVolume(ssrc_, volume);
}
-void AudioRtpReceiver::Stop() {
- // TODO(deadbeef): Need to do more here to fully stop receiving packets.
- if (!provider_) {
- return;
- }
- provider_->SetAudioPlayout(ssrc_, false);
- provider_ = nullptr;
-}
-
RtpParameters AudioRtpReceiver::GetParameters() const {
return provider_->GetAudioRtpReceiveParameters(ssrc_);
}
@@ -76,6 +67,15 @@ bool AudioRtpReceiver::SetParameters(const RtpParameters& parameters) {
return provider_->SetAudioRtpReceiveParameters(ssrc_, parameters);
}
+void AudioRtpReceiver::Stop() {
+ // TODO(deadbeef): Need to do more here to fully stop receiving packets.
+ if (!provider_) {
+ return;
+ }
+ provider_->SetAudioPlayout(ssrc_, false);
+ provider_ = nullptr;
+}
+
void AudioRtpReceiver::Reconfigure() {
if (!provider_) {
return;
@@ -112,6 +112,15 @@ VideoRtpReceiver::~VideoRtpReceiver() {
Stop();
}
+RtpParameters VideoRtpReceiver::GetParameters() const {
+ return provider_->GetVideoRtpReceiveParameters(ssrc_);
+}
+
+bool VideoRtpReceiver::SetParameters(const RtpParameters& parameters) {
+ TRACE_EVENT0("webrtc", "VideoRtpReceiver::SetParameters");
+ return provider_->SetVideoRtpReceiveParameters(ssrc_, parameters);
+}
+
void VideoRtpReceiver::Stop() {
// TODO(deadbeef): Need to do more here to fully stop receiving packets.
if (!provider_) {
@@ -123,13 +132,4 @@ void VideoRtpReceiver::Stop() {
provider_ = nullptr;
}
-RtpParameters VideoRtpReceiver::GetParameters() const {
- return provider_->GetVideoRtpReceiveParameters(ssrc_);
-}
-
-bool VideoRtpReceiver::SetParameters(const RtpParameters& parameters) {
- TRACE_EVENT0("webrtc", "VideoRtpReceiver::SetParameters");
- return provider_->SetVideoRtpReceiveParameters(ssrc_, parameters);
-}
-
} // namespace webrtc
« no previous file with comments | « webrtc/api/rtpreceiver.h ('k') | webrtc/api/rtpreceiverinterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698