Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2020633002: Revert of Replacing DtlsIdentityStoreInterface with RTCCertificateGeneratorInterface. (Closed)

Created:
4 years, 6 months ago by hbos
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Replacing DtlsIdentityStoreInterface with RTCCertificateGeneratorInterface. (patchset #2 id:20001 of https://codereview.webrtc.org/2013523002/ ) Reason for revert: There are more CreatePeerConnection calls than I anticipated/had found in Chromium, like remoting/protocol/webrtc_transport.cc. Reverting due to broken Chromium FYI bots. Original issue's description: > Replacing DtlsIdentityStoreInterface with RTCCertificateGeneratorInterface. > > The store was used in WebRtcSessionDescriptionFactory to generate certificates, > now a generator is used instead (new API). PeerConnection[Factory][Interface], > and WebRtcSession are updated to pass generators all the way down to the > WebRtcSessionDescriptionFactory instead of stores. > > The webrtc implementation of a generator, RTCCertificateGenerator, is used as > the default generator (peerconnectionfactory.cc:189) instead of the webrtc > implementation of a store, DtlsIdentityStoreImpl. > The generator is fully parameterized and does not generate RSA-1024 unless you > ask for it (which makes sense not to do beforehand since ECDSA is now default). > The store was not fully parameterized (known filed bug). > > The "top" layer, PeerConnectionFactoryInterface::CreatePeerConnection, is > updated to take a generator instead of a store. But as to not break Chromium, > the old function signature taking a store is kept. It is implemented to invoke > the generator version by wrapping the store in an > RTCCertificateGeneratorStoreWrapper. As soon as Chromium is updated to use the > new function signature we can remove the old CreatePeerConnection. > Due to having multiple CreatePeerConnection signatures, some calling places > are updated to resolve the ambiguity introduced. > > BUG=webrtc:5707, webrtc:5708 > R=phoglund@webrtc.org, tommi@webrtc.org > TBR=tkchin@webrc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/400781a2091d09a725b32c6953247036b22478e8 TBR=tkchin@webrtc.org,tommi@webrtc.org,phoglund@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5707, webrtc:5708 Committed: https://crrev.com/d7973ccdb54307ead8f9defba5ad77f929e36153 Cr-Commit-Position: refs/heads/master@{#12948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -212 lines) Patch
M talk/app/webrtc/objc/RTCPeerConnection.mm View 2 chunks +2 lines, -11 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/api/peerconnection.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/api/peerconnection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/peerconnectionfactory.h View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/api/peerconnectionfactory.cc View 6 chunks +26 lines, -28 lines 0 comments Download
M webrtc/api/peerconnectionfactoryproxy.h View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 2 chunks +2 lines, -37 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/api/webrtcsession.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsession.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/api/webrtcsessiondescriptionfactory.h View 6 chunks +37 lines, -28 lines 0 comments Download
M webrtc/api/webrtcsessiondescriptionfactory.cc View 6 chunks +85 lines, -59 lines 0 comments Download
M webrtc/examples/peerconnection/client/conductor.cc View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hbos
Created Revert of Replacing DtlsIdentityStoreInterface with RTCCertificateGeneratorInterface.
4 years, 6 months ago (2016-05-27 13:08:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020633002/1
4 years, 6 months ago (2016-05-27 13:08:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 13:08:58 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 13:09:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7973ccdb54307ead8f9defba5ad77f929e36153
Cr-Commit-Position: refs/heads/master@{#12948}

Powered by Google App Engine
This is Rietveld 408576698