Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2020623002: Turning FakeDtlsIdentityStore into FakeRTCCertificateGenerator. (Closed)

Created:
4 years, 6 months ago by hbos
Modified:
4 years, 6 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Turning FakeDtlsIdentityStore into FakeRTCCertificateGenerator. This is one less DtlsIdentityStoreInterface implementation, and one step closer to removing this interface in favor of RTCCertificateGeneratorInterface. This also removes PeerConnectionInterface::CreatePeerConnectionWithStore which is no longer needed. BUG=webrtc:5707, webrtc:5708 R=tommi@webrtc.org Committed: https://crrev.com/d79599d74aee6199b314907fcf7f70cc980d3497 Cr-Commit-Position: refs/heads/master@{#12990}

Patch Set 1 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -389 lines) Patch
M webrtc/api/api_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 7 chunks +21 lines, -21 lines 0 comments Download
M webrtc/api/peerconnectionfactory_unittest.cc View 8 chunks +35 lines, -42 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 1 chunk +0 lines, -34 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
D webrtc/api/test/fakedtlsidentitystore.h View 1 chunk +0 lines, -233 lines 0 comments Download
A + webrtc/api/test/fakertccertificategenerator.h View 6 chunks +21 lines, -27 lines 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 5 chunks +16 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hbos
Please take a look, tommi.
4 years, 6 months ago (2016-05-27 13:00:36 UTC) #2
tommi
lgtm
4 years, 6 months ago (2016-05-27 13:14:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020623002/20001
4 years, 6 months ago (2016-06-01 11:27:16 UTC) #8
hbos
4 years, 6 months ago (2016-06-01 11:59:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
d79599d74aee6199b314907fcf7f70cc980d3497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698