Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1779)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2020623002: Turning FakeDtlsIdentityStore into FakeRTCCertificateGenerator. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase with master Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/peerconnectionfactory_unittest.cc ('k') | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 3a1b8dd9889548cd0a6f4ba0ff32f63ef33201cd..5ff8019a0418a2072f72468159eeef3f3a8db873 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -603,46 +603,12 @@ class PeerConnectionFactoryInterface : public rtc::RefCountInterface {
std::unique_ptr<cricket::PortAllocator> allocator,
std::unique_ptr<rtc::RTCCertificateGeneratorInterface> cert_generator,
PeerConnectionObserver* observer) = 0;
- // TODO(hbos): To be removed in favor of the |cert_generator| version as soon
- // as unittests stop using this version. See bugs.webrtc.org/5707,
- // bugs.webrtc.org/5708.
- rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnectionWithStore(
- const PeerConnectionInterface::RTCConfiguration& configuration,
- const MediaConstraintsInterface* constraints,
- std::unique_ptr<cricket::PortAllocator> allocator,
- std::unique_ptr<DtlsIdentityStoreInterface> dtls_identity_store,
- PeerConnectionObserver* observer) {
- return CreatePeerConnection(
- configuration,
- constraints,
- std::move(allocator),
- std::unique_ptr<rtc::RTCCertificateGeneratorInterface>(
- dtls_identity_store ? new RTCCertificateGeneratorStoreWrapper(
- std::move(dtls_identity_store)) : nullptr),
- observer);
- }
virtual rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection(
const PeerConnectionInterface::RTCConfiguration& configuration,
std::unique_ptr<cricket::PortAllocator> allocator,
std::unique_ptr<rtc::RTCCertificateGeneratorInterface> cert_generator,
PeerConnectionObserver* observer) = 0;
- // TODO(hbos): To be removed in favor of the |cert_generator| version as soon
- // as unittests stop using this version. See bugs.webrtc.org/5707,
- // bugs.webrtc.org/5708.
- rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnectionWithStore(
- const PeerConnectionInterface::RTCConfiguration& configuration,
- std::unique_ptr<cricket::PortAllocator> allocator,
- std::unique_ptr<DtlsIdentityStoreInterface> dtls_identity_store,
- PeerConnectionObserver* observer) {
- return CreatePeerConnection(
- configuration,
- std::move(allocator),
- std::unique_ptr<rtc::RTCCertificateGeneratorInterface>(
- dtls_identity_store ? new RTCCertificateGeneratorStoreWrapper(
- std::move(dtls_identity_store)) : nullptr),
- observer);
- }
virtual rtc::scoped_refptr<MediaStreamInterface>
CreateLocalMediaStream(const std::string& label) = 0;
« no previous file with comments | « webrtc/api/peerconnectionfactory_unittest.cc ('k') | webrtc/api/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698