AudioDecoderIsacT: Require caller to always specify sample rate

AudioDecoderIsacT: Require caller to always specify sample rate

This gets rid of the complex & icky state where the sample rate is not
yet determined.

BUG=webrtc:5801
Committed: https://crrev.com/abe95ba323e27f7cb758c75a974dd9b4e2a7edd6
Cr-Commit-Position: refs/heads/master@{#13011}

[kwiberg-webrtc, 2016-06-01 11:46:43]

Patchset #2 (id:20001) has been deleted

[kwiberg-webrtc, 2016-06-01 11:46:51]

Patchset #1 (id:1) has been deleted

[kwiberg-webrtc, 2016-06-01 12:52:39]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, pbos@webrtc.org, perkj@webrtc.org,
solenberg@webrtc.org

[kwiberg-webrtc, 2016-06-01 12:52:39]

This cuts across a bunch of OWNER areas:

modules/audio_coding: hlundin (+ main reviewer for the whole CL)
modules/utility: perkj
test/fuzzers: pbos
voice_engine: solenberg

[hlundin-webrtc, 2016-06-01 13:41:31]

lgtm

[pbos-webrtc, 2016-06-01 14:10:45]

test/fuzzers lgtm

[the sun, 2016-06-01 17:50:11]

lgtm

[perkj_webrtc, 2016-06-01 20:04:40]

please make your self an owner of the file you need to change in utility or move
it to an appropriate location. I know nothin about codec.cc.

https://codereview.webrtc.org/2020353003/diff/40001/webrtc/modules/utility/so...
File webrtc/modules/utility/source/coder.cc (right):

https://codereview.webrtc.org/2020353003/diff/40001/webrtc/modules/utility/so...
webrtc/modules/utility/source/coder.cc:48: if
(acm_->RegisterReceiveCodec(codec_inst, [&] {
FYI capture all lambdas are not allowed according to google style guide. One
reason being that its too easy to make lifetime mistakes.

[kwiberg-webrtc, 2016-06-02 08:23:16]

https://codereview.webrtc.org/2020353003/diff/40001/webrtc/modules/utility/so...
File webrtc/modules/utility/source/coder.cc (right):

https://codereview.webrtc.org/2020353003/diff/40001/webrtc/modules/utility/so...
webrtc/modules/utility/source/coder.cc:48: if
(acm_->RegisterReceiveCodec(codec_inst, [&] {
On 2016/06/01 20:04:40, perkj_webrtc wrote:
> FYI capture all lambdas are not allowed according to google style guide. One
> reason being that its too easy to make lifetime mistakes. 

They relaxed the rules slightly (some months ago IIRC). The relevant part now
reads, "Use default captures judiciously, when it aids readability. In
particular, prefer to write lambda captures explicitly when capturing this or if
the lambda will escape the current scope."

In this case, the lambda will not escape the current scope (because
RegisterReceiveCodec will just invoke it, not save it), so a default capture is
fine.

[the sun, 2016-06-02 09:04:02]

On 2016/06/02 08:23:16, kwiberg-webrtc wrote:
>
https://codereview.webrtc.org/2020353003/diff/40001/webrtc/modules/utility/so...
> File webrtc/modules/utility/source/coder.cc (right):
> 
>
https://codereview.webrtc.org/2020353003/diff/40001/webrtc/modules/utility/so...
> webrtc/modules/utility/source/coder.cc:48: if
> (acm_->RegisterReceiveCodec(codec_inst, [&] {
> On 2016/06/01 20:04:40, perkj_webrtc wrote:
> > FYI capture all lambdas are not allowed according to google style guide. One
> > reason being that its too easy to make lifetime mistakes. 
> 
> They relaxed the rules slightly (some months ago IIRC). The relevant part now
> reads, "Use default captures judiciously, when it aids readability. In
> particular, prefer to write lambda captures explicitly when capturing this or
if
> the lambda will escape the current scope."
> 
> In this case, the lambda will not escape the current scope (because
> RegisterReceiveCodec will just invoke it, not save it), so a default capture
is
> fine.

LGTM for coder.cc as well. After discussion with kwiberg@ we've decided to move
FilePlayer, FileRecorder and AudioCoder to voice_engine instead, since this is
the only place where it is used in WebRTC.

perkj@, are you OK to rubber stamp the CL with that promise?

[perkj_webrtc, 2016-06-02 09:28:48]

On 2016/06/02 09:04:02, the sun wrote:
> On 2016/06/02 08:23:16, kwiberg-webrtc wrote:
> >
>
https://codereview.webrtc.org/2020353003/diff/40001/webrtc/modules/utility/so...
> > File webrtc/modules/utility/source/coder.cc (right):
> > 
> >
>
https://codereview.webrtc.org/2020353003/diff/40001/webrtc/modules/utility/so...
> > webrtc/modules/utility/source/coder.cc:48: if
> > (acm_->RegisterReceiveCodec(codec_inst, [&] {
> > On 2016/06/01 20:04:40, perkj_webrtc wrote:
> > > FYI capture all lambdas are not allowed according to google style guide.
One
> > > reason being that its too easy to make lifetime mistakes. 
> > 
> > They relaxed the rules slightly (some months ago IIRC). The relevant part
now
> > reads, "Use default captures judiciously, when it aids readability. In
> > particular, prefer to write lambda captures explicitly when capturing this
or
> if
> > the lambda will escape the current scope."
> > 
> > In this case, the lambda will not escape the current scope (because
> > RegisterReceiveCodec will just invoke it, not save it), so a default capture
> is
> > fine.
> 
> LGTM for coder.cc as well. After discussion with kwiberg@ we've decided to
move
> FilePlayer, FileRecorder and AudioCoder to voice_engine instead, since this is
> the only place where it is used in WebRTC.
> 
> perkj@, are you OK to rubber stamp the CL with that promise?

sure
rs lgtm

[kwiberg-webrtc, 2016-06-02 09:49:54]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-06-02 09:50:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020353003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020353003/40001

[commit-bot: I haz the power, 2016-06-02 09:59:02]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-06-02 09:59:07]

Description was changed from

==========
AudioDecoderIsacT: Require caller to always specify sample rate

This gets rid of the complex & icky state where the sample rate is not
yet determined.

BUG=webrtc:5801
==========

to

==========
AudioDecoderIsacT: Require caller to always specify sample rate

This gets rid of the complex & icky state where the sample rate is not
yet determined.

BUG=webrtc:5801

Committed: https://crrev.com/abe95ba323e27f7cb758c75a974dd9b4e2a7edd6
Cr-Commit-Position: refs/heads/master@{#13011}
==========

[commit-bot: I haz the power, 2016-06-02 09:59:08]

Patchset 1 (id:??) landed as
https://crrev.com/abe95ba323e27f7cb758c75a974dd9b4e2a7edd6
Cr-Commit-Position: refs/heads/master@{#13011}