Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2020243005: Minor lint-fixes in MediaChannel and VideoEngine2. (Closed)

Created:
4 years, 6 months ago by terelius
Modified:
4 years, 6 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor lint-fixes in MediaChannel and VideoEngine2. Committed: https://crrev.com/54f9171b3f47734bf32f73eb3c7b5e89c9b3320a Cr-Commit-Position: refs/heads/master@{#12996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M webrtc/media/base/mediachannel.h View 4 chunks +6 lines, -3 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
terelius
4 years, 6 months ago (2016-06-01 11:17:16 UTC) #2
pbos-webrtc
lgtm
4 years, 6 months ago (2016-06-01 11:35:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020243005/1
4 years, 6 months ago (2016-06-01 11:51:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 6 months ago (2016-06-01 13:51:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2020243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2020243005/1
4 years, 6 months ago (2016-06-01 18:04:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 18:19:01 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 18:19:06 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/54f9171b3f47734bf32f73eb3c7b5e89c9b3320a
Cr-Commit-Position: refs/heads/master@{#12996}

Powered by Google App Engine
This is Rietveld 408576698