Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: webrtc/media/base/mediachannel.h

Issue 2020243005: Minor lint-fixes in MediaChannel and VideoEngine2. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/mediachannel.h
diff --git a/webrtc/media/base/mediachannel.h b/webrtc/media/base/mediachannel.h
index ee431537b965fd7558728cf9bb6134ff3ac7ab7b..3e66bcb746802bb9d4d23d255be6825fcffbcec9 100644
--- a/webrtc/media/base/mediachannel.h
+++ b/webrtc/media/base/mediachannel.h
@@ -11,6 +11,7 @@
#ifndef WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_
#define WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_
+#include <algorithm>
#include <memory>
#include <string>
#include <vector>
@@ -352,7 +353,7 @@ class MediaChannel : public sigslot::has_slots<> {
virtual ~NetworkInterface() {}
};
- MediaChannel(const MediaConfig& config)
+ explicit MediaChannel(const MediaConfig& config)
: enable_dscp_(config.enable_dscp), network_interface_(NULL) {}
MediaChannel() : enable_dscp_(false), network_interface_(NULL) {}
virtual ~MediaChannel() {}
@@ -886,7 +887,8 @@ class VoiceMediaChannel : public MediaChannel {
};
VoiceMediaChannel() {}
- VoiceMediaChannel(const MediaConfig& config) : MediaChannel(config) {}
+ explicit VoiceMediaChannel(const MediaConfig& config)
+ : MediaChannel(config) {}
virtual ~VoiceMediaChannel() {}
virtual bool SetSendParameters(const AudioSendParameters& params) = 0;
virtual bool SetRecvParameters(const AudioRecvParameters& params) = 0;
@@ -970,7 +972,8 @@ class VideoMediaChannel : public MediaChannel {
};
VideoMediaChannel() {}
- VideoMediaChannel(const MediaConfig& config) : MediaChannel(config) {}
+ explicit VideoMediaChannel(const MediaConfig& config)
+ : MediaChannel(config) {}
virtual ~VideoMediaChannel() {}
virtual bool SetSendParameters(const VideoSendParameters& params) = 0;
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698