Fixing neteq_rtpplay

Fixing neteq_rtpplay

A regression happened in https://codereview.webrtc.org/2006723002,
causing neteq_rtpplay not to work. The problem was that when the main
code was moved inside of the webrtc::test namespace, it was no longer
visible to the linker. Meanwhile, the dependency on test_support_main
rather than test_support caused the executable to be a gtest.

In this fix, the gyp dependencies are corrected, and a main method is
added outside of the namespaces.

NOTRY=True

Committed: https://crrev.com/303d3e17823cfbef1275191627a5df53e729ffd8
Cr-Commit-Position: refs/heads/master@{#12918}

[hlundin-webrtc, 2016-05-26 08:23:51]

henrik.lundin@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[hlundin-webrtc, 2016-05-26 08:23:51]

Ivo, please, take a look.

[hlundin-webrtc, 2016-05-26 08:24:20]

Description was changed from

==========
Fixing neteq_rtpplay

A regression happened in https://codereview.webrtc.org/2006723002,
causing neteq_rtpplay not to work. The problem was that when the main
code was moved inside of the webrtc::test namespace, it was no longer
visible to the linker. Meanwhile, the dependency on test_support_main
rather than test_support caused the executable to be a gtest.

In this fix, the gyp dependencies are corrected, and a main method is
added outside of the namespaces.
==========

to

==========
Fixing neteq_rtpplay

A regression happened in https://codereview.webrtc.org/2006723002,
causing neteq_rtpplay not to work. The problem was that when the main
code was moved inside of the webrtc::test namespace, it was no longer
visible to the linker. Meanwhile, the dependency on test_support_main
rather than test_support caused the executable to be a gtest.

In this fix, the gyp dependencies are corrected, and a main method is
added outside of the namespaces.

NOTRY=True
==========

[ivoc, 2016-05-26 08:38:11]

Looks good, just one question, see below.

https://codereview.webrtc.org/2018473002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc (right):

https://codereview.webrtc.org/2018473002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc:373: int RunTest(int
argc, char* argv[]) {
Is it necessary for this function to be outside of the anonymous namespace?

[hlundin-webrtc, 2016-05-26 11:20:37]

All but main in unnamed namespace

[hlundin-webrtc, 2016-05-26 11:20:59]

PTAL again.

https://codereview.webrtc.org/2018473002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc (right):

https://codereview.webrtc.org/2018473002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc:373: int RunTest(int
argc, char* argv[]) {
On 2016/05/26 08:38:11, ivoc wrote:
> Is it necessary for this function to be outside of the anonymous namespace?

No, you are right. I fixed that.

[ivoc, 2016-05-26 11:37:22]

LGTM.

[hlundin-webrtc, 2016-05-26 12:54:26]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-05-26 12:54:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018473002/20001

[commit-bot: I haz the power, 2016-05-26 12:56:08]

Description was changed from

==========
Fixing neteq_rtpplay

A regression happened in https://codereview.webrtc.org/2006723002,
causing neteq_rtpplay not to work. The problem was that when the main
code was moved inside of the webrtc::test namespace, it was no longer
visible to the linker. Meanwhile, the dependency on test_support_main
rather than test_support caused the executable to be a gtest.

In this fix, the gyp dependencies are corrected, and a main method is
added outside of the namespaces.

NOTRY=True
==========

to

==========
Fixing neteq_rtpplay

A regression happened in https://codereview.webrtc.org/2006723002,
causing neteq_rtpplay not to work. The problem was that when the main
code was moved inside of the webrtc::test namespace, it was no longer
visible to the linker. Meanwhile, the dependency on test_support_main
rather than test_support caused the executable to be a gtest.

In this fix, the gyp dependencies are corrected, and a main method is
added outside of the namespaces.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-05-26 12:56:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-26 12:56:17]

Description was changed from

==========
Fixing neteq_rtpplay

A regression happened in https://codereview.webrtc.org/2006723002,
causing neteq_rtpplay not to work. The problem was that when the main
code was moved inside of the webrtc::test namespace, it was no longer
visible to the linker. Meanwhile, the dependency on test_support_main
rather than test_support caused the executable to be a gtest.

In this fix, the gyp dependencies are corrected, and a main method is
added outside of the namespaces.

NOTRY=True
==========

to

==========
Fixing neteq_rtpplay

A regression happened in https://codereview.webrtc.org/2006723002,
causing neteq_rtpplay not to work. The problem was that when the main
code was moved inside of the webrtc::test namespace, it was no longer
visible to the linker. Meanwhile, the dependency on test_support_main
rather than test_support caused the executable to be a gtest.

In this fix, the gyp dependencies are corrected, and a main method is
added outside of the namespaces.

NOTRY=True

Committed: https://crrev.com/303d3e17823cfbef1275191627a5df53e729ffd8
Cr-Commit-Position: refs/heads/master@{#12918}
==========

[commit-bot: I haz the power, 2016-05-26 12:56:18]

Patchset 2 (id:??) landed as
https://crrev.com/303d3e17823cfbef1275191627a5df53e729ffd8
Cr-Commit-Position: refs/heads/master@{#12918}