Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2006723002: Move neteq_rtpplay.cc inside webrtc::test namespace (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move neteq_rtpplay.cc inside webrtc::test namespace This simplifies the code. BUG=webrtc:2692 Committed: https://crrev.com/ce5570e54ebd03cf51f08ccd25dd02b4eccd2900 Cr-Commit-Position: refs/heads/master@{#12873}

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -100 lines) Patch
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 1 16 chunks +89 lines, -100 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hlundin-webrtc
git cl format
4 years, 7 months ago (2016-05-23 14:40:14 UTC) #1
hlundin-webrtc
Ivo, Please, take a look. Patch set 1 does the actual change; patch set 2 ...
4 years, 7 months ago (2016-05-23 14:41:33 UTC) #3
ivoc
Nice change, the code looks better indeed. LGTM.
4 years, 7 months ago (2016-05-24 07:30:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006723002/20001
4 years, 7 months ago (2016-05-24 07:40:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-24 09:41:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006723002/20001
4 years, 7 months ago (2016-05-24 13:13:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 13:15:02 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 13:15:12 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ce5570e54ebd03cf51f08ccd25dd02b4eccd2900
Cr-Commit-Position: refs/heads/master@{#12873}

Powered by Google App Engine
This is Rietveld 408576698