Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2017453002: Excluding some PhysicalSocketTest tests on memcheck. (Closed)

Created:
4 years, 7 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Excluding some PhysicalSocketTest tests on memcheck. NOTRY=True Committed: https://crrev.com/2ce871548f7385cd273e5a97d6ca72b3af8a6229 Cr-Commit-Position: refs/heads/master@{#12914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -3 lines 0 comments Download
A tools/valgrind-webrtc/gtest_exclude/webrtc_nonparallel_tests.gtest-memcheck.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Taylor Brandstetter
4 years, 7 months ago (2016-05-25 20:44:04 UTC) #2
kjellander_webrtc
Hmm, this seems to be exactly what's needed to fix failures like https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/6007 but I ...
4 years, 7 months ago (2016-05-26 07:35:04 UTC) #5
kjellander_webrtc
On 2016/05/26 07:35:04, kjellander (webrtc) wrote: > Hmm, this seems to be exactly what's needed ...
4 years, 7 months ago (2016-05-26 08:03:55 UTC) #6
kjellander_webrtc
I'm committing this since the failures causes noise in the commit waterfall and that https://codereview.webrtc.org/2016613003/ ...
4 years, 7 months ago (2016-05-26 10:58:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2017453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2017453002/1
4 years, 7 months ago (2016-05-26 10:58:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 11:03:50 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 11:03:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ce871548f7385cd273e5a97d6ca72b3af8a6229
Cr-Commit-Position: refs/heads/master@{#12914}

Powered by Google App Engine
This is Rietveld 408576698