Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2016613003: Add memcheck suppression hitting only our linux_memcheck trybot. (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add memcheck suppression hitting only our linux_memcheck trybot. It seems the GCE VMs that are used for our trybots have slightly different OS/libc versions than the Chrome infra Golo VMs, causing it to fail with the current suppressions. This should make it go green. See https://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/4374 for an example. NOTRY=True TBR=deadbeef@webrtc.org Committed: https://crrev.com/2e15593803a81d3e8be4a954748054014ccc1ea6 Cr-Commit-Position: refs/heads/master@{#12912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
4 years, 7 months ago (2016-05-26 08:05:02 UTC) #3
kjellander_webrtc
Woho, now it's green!
4 years, 7 months ago (2016-05-26 10:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016613003/1
4 years, 7 months ago (2016-05-26 10:56:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 10:57:54 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 10:58:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e15593803a81d3e8be4a954748054014ccc1ea6
Cr-Commit-Position: refs/heads/master@{#12912}

Powered by Google App Engine
This is Rietveld 408576698