Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK.

Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK. (patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ )

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues earlier since assert() is left out in release builds, including builds with DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past buffer boundaries or continuing on in a failed state.
>
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
>
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:613482
Committed: https://crrev.com/ba189cc4f4f6fe311a815646059e8011ffa53894
Cr-Commit-Position: refs/heads/master@{#12907}

[tommi, 2016-05-26 08:13:35]

Created Reland of Adding a some checks and switching out a few assert for
RTC_[D]CHECK.

[tommi, 2016-05-26 08:14:31]

Description was changed from

==========
Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK.
(patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ )

Reason for revert:
Relanding

Original issue's description:
> Revert of Adding a some checks and switching out a few assert for
RTC_[D]CHECK. (patchset #6 id:100001 of
https://codereview.webrtc.org/2007563002/ )
> 
> Reason for revert:
> Reverting temporarily.  Need to fix tests downstream that pass invalid
arguments.
> 
> Original issue's description:
> > Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> > These changes are around use of AudioFrame.data_ to help us catch issues
earlier since assert() is left out in release builds, including builds with
DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past
buffer boundaries or continuing on in a failed state.
> >
> > BUG=chromium:613482
> > NOTRY=true
> > (using notry due to offline android_arm64_rel bot)
> >
> > Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> > Cr-Commit-Position: refs/heads/master@{#12870}
> 
> TBR=henrik.lundin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:613482
> 
> Committed: https://crrev.com/fb98b9edb445244cf5ad7fa7a69a5a95da854fd7
> Cr-Commit-Position: refs/heads/master@{#12874}

TBR=henrik.lundin@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:613482
==========

to

==========
Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK.
(patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ )

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues
earlier since assert() is left out in release builds, including builds with
DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past
buffer boundaries or continuing on in a failed state.
>
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
>
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:613482
==========

[tommi, 2016-05-26 08:15:40]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-26 08:15:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009253004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009253004/1

[tommi, 2016-05-26 08:35:44]

The CQ bit was unchecked by tommi@webrtc.org

[tommi, 2016-05-26 08:35:50]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2016-05-26 08:35:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009253004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009253004/1

[commit-bot: I haz the power, 2016-05-26 09:13:11]

Description was changed from

==========
Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK.
(patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ )

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues
earlier since assert() is left out in release builds, including builds with
DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past
buffer boundaries or continuing on in a failed state.
>
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
>
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:613482
==========

to

==========
Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK.
(patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ )

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues
earlier since assert() is left out in release builds, including builds with
DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past
buffer boundaries or continuing on in a failed state.
>
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
>
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:613482
==========

[commit-bot: I haz the power, 2016-05-26 09:13:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-26 09:13:20]

Description was changed from

==========
Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK.
(patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ )

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues
earlier since assert() is left out in release builds, including builds with
DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past
buffer boundaries or continuing on in a failed state.
>
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
>
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:613482
==========

to

==========
Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK.
(patchset #1 id:1 of https://codereview.webrtc.org/2006243002/ )

Original issue's description:
> Adding a some checks and switching out a few assert for RTC_[D]CHECK.
> These changes are around use of AudioFrame.data_ to help us catch issues
earlier since assert() is left out in release builds, including builds with
DCHECK enabled.  I've also added a few full-on CHECKs to avoid reading past
buffer boundaries or continuing on in a failed state.
>
> BUG=chromium:613482
> NOTRY=true
> (using notry due to offline android_arm64_rel bot)
>
> Committed: https://crrev.com/d36df89d40bde3c62ee5cbff841933e50b3c007b
> Cr-Commit-Position: refs/heads/master@{#12870}

TBR=henrik.lundin@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:613482

Committed: https://crrev.com/ba189cc4f4f6fe311a815646059e8011ffa53894
Cr-Commit-Position: refs/heads/master@{#12907}
==========

[commit-bot: I haz the power, 2016-05-26 09:13:21]

Patchset 1 (id:??) landed as
https://crrev.com/ba189cc4f4f6fe311a815646059e8011ffa53894
Cr-Commit-Position: refs/heads/master@{#12907}

[kjellander_webrtc, 2016-05-26 09:46:40]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2006313009/ by kjellander@webrtc.org.

The reason for reverting is: Fails unexpectedly on multiple commit bots:
https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug%20%28Clang%...
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%...

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=614967 to track
the problem. I'll reland if it doesn't solve the problem..

[tommi, 2016-05-26 15:14:50]

On 2016/05/26 09:46:40, kjellander (webrtc) wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.webrtc.org/2006313009/ by mailto:kjellander@webrtc.org.
> 
> The reason for reverting is: Fails unexpectedly on multiple commit bots:
>
https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug%20%28Clang%...
>
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%...
> 
> I filed https://bugs.chromium.org/p/chromium/issues/detail?id=614967 to track
> the problem. I'll reland if it doesn't solve the problem..

The failures are on different executables and very much look like there was
actually a problem with allocating disk space.  How certain are you that at the
point the failures happened, there was plenty of disk space?

[tommi, 2016-05-26 15:21:22]

On 2016/05/26 15:14:50, tommi-webrtc wrote:
> On 2016/05/26 09:46:40, kjellander (webrtc) wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.webrtc.org/2006313009/ by mailto:kjellander@webrtc.org.
> > 
> > The reason for reverting is: Fails unexpectedly on multiple commit bots:
> >
>
https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug%20%28Clang%...
> >
>
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%...
> > 
> > I filed https://bugs.chromium.org/p/chromium/issues/detail?id=614967 to
track
> > the problem. I'll reland if it doesn't solve the problem..
> 
> The failures are on different executables and very much look like there was
> actually a problem with allocating disk space.  How certain are you that at
the
> point the failures happened, there was plenty of disk space?

A case in point, this failure occurred after this revert, so the CL that was
reverted, doesn't have anything to do with it:
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug%20%28Clang%...