Reland of Adding a some checks and switching out a few assert for RTC_[D]CHECK.

webrtc/common_audio/resampler/push_resampler.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/common_audio/resampler/include/push_resampler.h"
 
 #include <string.h>
 
+#include "webrtc/base/checks.h"
 #include "webrtc/common_audio/include/audio_util.h"
 #include "webrtc/common_audio/resampler/include/resampler.h"
 #include "webrtc/common_audio/resampler/push_sinc_resampler.h"
 
 namespace webrtc {
 
 template <typename T>
 PushResampler<T>::PushResampler()
     : src_sample_rate_hz_(0),
       dst_sample_rate_hz_(0),
       num_channels_(0) {
 }
 
 template <typename T>
 PushResampler<T>::~PushResampler() {
 }
 
 template <typename T>
 int PushResampler<T>::InitializeIfNeeded(int src_sample_rate_hz,
                                          int dst_sample_rate_hz,
                                          size_t num_channels) {
+  RTC_DCHECK_GT(src_sample_rate_hz, 0);
+  RTC_DCHECK_GT(dst_sample_rate_hz, 0);
+  RTC_DCHECK_GT(num_channels, 0u);
+  RTC_DCHECK_LE(num_channels, 2u);
+
   if (src_sample_rate_hz == src_sample_rate_hz_ &&
       dst_sample_rate_hz == dst_sample_rate_hz_ &&
-      num_channels == num_channels_)
+      num_channels == num_channels_) {
     // No-op if settings haven't changed.
     return 0;
+  }
 
-  if (src_sample_rate_hz <= 0 || dst_sample_rate_hz <= 0 ||
-      num_channels <= 0 || num_channels > 2)
+  if (src_sample_rate_hz <= 0 || dst_sample_rate_hz <= 0 || num_channels <= 0 ||
+      num_channels > 2) {
     return -1;
+  }
 
   src_sample_rate_hz_ = src_sample_rate_hz;
   dst_sample_rate_hz_ = dst_sample_rate_hz;
   num_channels_ = num_channels;
 
   const size_t src_size_10ms_mono =
       static_cast<size_t>(src_sample_rate_hz / 100);
   const size_t dst_size_10ms_mono =
       static_cast<size_t>(dst_sample_rate_hz / 100);
   sinc_resampler_.reset(new PushSincResampler(src_size_10ms_mono,
                                               dst_size_10ms_mono));
   if (num_channels_ == 2) {
     src_left_.reset(new T[src_size_10ms_mono]);
     src_right_.reset(new T[src_size_10ms_mono]);
     dst_left_.reset(new T[dst_size_10ms_mono]);
     dst_right_.reset(new T[dst_size_10ms_mono]);
     sinc_resampler_right_.reset(new PushSincResampler(src_size_10ms_mono,
                                                       dst_size_10ms_mono));
   }
 
   return 0;
 }
 
 template <typename T>
 int PushResampler<T>::Resample(const T* src, size_t src_length, T* dst,
                                size_t dst_capacity) {
   const size_t src_size_10ms = src_sample_rate_hz_ * num_channels_ / 100;
   const size_t dst_size_10ms = dst_sample_rate_hz_ * num_channels_ / 100;
+  RTC_CHECK_EQ(src_length, src_size_10ms);
+  RTC_CHECK_GE(dst_capacity, dst_size_10ms);
   if (src_length != src_size_10ms || dst_capacity < dst_size_10ms)
     return -1;
 
   if (src_sample_rate_hz_ == dst_sample_rate_hz_) {
     // The old resampler provides this memcpy facility in the case of matching
     // sample rates, so reproduce it here for the sinc resampler.
     memcpy(dst, src, src_length * sizeof(T));
     return static_cast<int>(src_length);
   }
   if (num_channels_ == 2) {
@@ skipping 16 matching lines @@
     return static_cast<int>(
         sinc_resampler_->Resample(src, src_length, dst, dst_capacity));
   }
 }
 
 // Explictly generate required instantiations.
 template class PushResampler<int16_t>;
 template class PushResampler<float>;
 
 }  // namespace webrtc