webrtc/modules/pacing/bitrate_prober.cc - Issue 2005313003: Propagate probing cluster id to SendTimeHistory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/pacing/bitrate_prober.cc

Issue 2005313003: Propagate probing cluster id to SendTimeHistory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback fixes. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/congestion_controller/congestion_controller.cc ('K') | « webrtc/modules/congestion_controller/congestion_controller.cc ('k') | webrtc/modules/pacing/paced_sender.h » ('j') | webrtc/modules/pacing/paced_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/pacing/bitrate_prober.cc

diff --git a/webrtc/modules/pacing/bitrate_prober.cc b/webrtc/modules/pacing/bitrate_prober.cc

index 8e8e36ea34be202017e81ff584bb9ec7b26e9079..19eaff7a69ad3fbce234bd3714b8f1756d87353f 100644

--- a/webrtc/modules/pacing/bitrate_prober.cc

+++ b/webrtc/modules/pacing/bitrate_prober.cc

@@ -154,6 +154,8 @@ void BitrateProber::PacketSent(int64_t now_ms, size_t packet_size) {

++cluster->sent_probe_packets;

if (cluster->sent_probe_packets == cluster->max_probe_packets)

clusters_.pop();

+ if (clusters_.empty())

+ probing_state_ = kWait;

stefan-webrtc 2016/05/26 16:29:49 Could you add a unittest which covers this issue?

}

} // namespace webrtc