webrtc/modules/pacing/bitrate_prober.cc - Issue 2005313003: Propagate probing cluster id to SendTimeHistory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/pacing/bitrate_prober.cc

Issue 2005313003: Propagate probing cluster id to SendTimeHistory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Feedback fixes. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« webrtc/modules/congestion_controller/congestion_controller.cc ('K') | « webrtc/modules/congestion_controller/congestion_controller.cc ('k') | webrtc/modules/pacing/paced_sender.h » ('j') | webrtc/modules/pacing/paced_sender.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 136 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
147 return;	147 return;

148 packet_size_last_send_ = packet_size;	148 packet_size_last_send_ = packet_size;

149 time_last_send_ms_ = now_ms;	149 time_last_send_ms_ = now_ms;

150 if (probing_state_ != kProbing)	150 if (probing_state_ != kProbing)

151 return;	151 return;

152 if (!clusters_.empty()) {	152 if (!clusters_.empty()) {

153 ProbeCluster* cluster = &clusters_.front();	153 ProbeCluster* cluster = &clusters_.front();

154 ++cluster->sent_probe_packets;	154 ++cluster->sent_probe_packets;

155 if (cluster->sent_probe_packets == cluster->max_probe_packets)	155 if (cluster->sent_probe_packets == cluster->max_probe_packets)

156 clusters_.pop();	156 clusters_.pop();

	157 if (clusters_.empty())

	158 probing_state_ = kWait;
	stefan-webrtc 2016/05/26 16:29:49 Could you add a unittest which covers this issue? Could you add a unittest which covers this issue?
157 }	159 }

158 }	160 }

159 } // namespace webrtc	161 } // namespace webrtc

OLD	NEW