webrtc/modules/audio_coding/codecs/ilbc/smooth.c - Issue 2000403006: Fix UBSan errors (left shift of negative value)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/ilbc/smooth.c

Issue 2000403006: Fix UBSan errors (left shift of negative value) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/ilbc/smooth.c

diff --git a/webrtc/modules/audio_coding/codecs/ilbc/smooth.c b/webrtc/modules/audio_coding/codecs/ilbc/smooth.c

index f58e72c178f4a26d59a2aee3eb82d9ee1095504f..58b37ee31cc99a4959c8f1f1b5d4ea93521bdd96 100644

--- a/webrtc/modules/audio_coding/codecs/ilbc/smooth.c

+++ b/webrtc/modules/audio_coding/codecs/ilbc/smooth.c

@@ -165,7 +165,7 @@ void WebRtcIlbcfix_Smooth(

/* B_W32 is in Q30 ( B = 1 - ENH_A0/2 - A * w10/w00 ) */

scale1 = 31-bitsw10;

scale2 = 21-scale1;

- w10prim = w10 << scale1;

+ w10prim = w10 * (1 << scale1);

w00prim = WEBRTC_SPL_SHIFT_W32(w00, -scale2);

scale = bitsw00-scale2-15;

« no previous file with comments | « webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c ('k') | no next file » | no next file with comments »