webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c - Issue 2000403006: Fix UBSan errors (left shift of negative value)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c

Issue 2000403006: Fix UBSan errors (left shift of negative value) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c

diff --git a/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c b/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c

index 1c0fd42383721f544b24c7a4978483cfd254e6dd..61b9d2606a3f1132917ec301a23c52cd41858f76 100644

--- a/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c

+++ b/webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c

@@ -152,7 +152,7 @@ size_t WebRtcIlbcfix_EnhancerInterface( /* (o) Estimated lag in end of in[] */

corr16[i] = (int16_t)WEBRTC_SPL_SHIFT_W32(corrmax[i], corrSh);

corr16[i] = (int16_t)((corr16[i] * corr16[i]) >> 16);

en16[i] = (int16_t)WEBRTC_SPL_SHIFT_W32(ener, enerSh);

- totsh[i] = enerSh - (corrSh << 1);

+ totsh[i] = enerSh - 2 * corrSh;

}

/* Compare lagmax[0..3] for the (corr^2)/ener criteria */

« no previous file with comments | « no previous file | webrtc/modules/audio_coding/codecs/ilbc/smooth.c » ('j') | no next file with comments »