Chromium Code Reviews

Issue 2000403006: Fix UBSan errors (left shift of negative value) (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix UBSan errors (left shift of negative value) BUG=chromium:601787 Committed: https://crrev.com/4f6c2b6eff60d31873365d59710906c59d2937c9 Cr-Commit-Position: refs/heads/master@{#12911}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -2 lines)
M webrtc/modules/audio_coding/codecs/ilbc/enhancer_interface.c View 1 chunk +1 line, -1 line 0 comments
M webrtc/modules/audio_coding/codecs/ilbc/smooth.c View 1 chunk +1 line, -1 line 0 comments

Dependent Patchsets:

Issue 2014023002 Patch 20001
Issue 2014023002 Patch 40001
Issue 2014023002 Patch 60001
Issue 2014023002 Patch 80001

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 7 months ago (2016-05-25 22:29:35 UTC) #2
tlegrand-webrtc
lgtm
4 years, 7 months ago (2016-05-26 09:33:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000403006/1
4 years, 7 months ago (2016-05-26 09:43:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 10:40:54 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 10:41:02 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4f6c2b6eff60d31873365d59710906c59d2937c9
Cr-Commit-Position: refs/heads/master@{#12911}

Powered by Google App Engine