Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1991513004: Revert of FrameBuffer for the new jitter buffer. (Closed)

Created:
4 years, 7 months ago by honghaiz3
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of FrameBuffer for the new jitter buffer. (patchset #9 id:160001 of https://codereview.webrtc.org/1969403007/ ) Reason for revert: Two tests added by this CL failed in Win DrMemory Full: TestFrameBuffer2.OneLayerStreamReordered - TestFrameBuffer2.WaitForFrame See the link here: https://build.chromium.org/p/client.webrtc/waterfall?builder=Win%20DrMemory%20Full Original issue's description: > FrameBuffer for the new jitter buffer. > > BUG=webrtc:5514 > R=danilchap@webrtc.org, mflodman@webrtc.org > > Committed: https://crrev.com/a376e70cf9d0df3c35d53533b454da542661775b > Cr-Commit-Position: refs/heads/master@{#12798} TBR=mflodman@webrtc.org,danilchap@webrtc.org,philipel@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5514 Committed: https://crrev.com/b711f10d9683b9de6ee78186f77b225fc7ebfb8f Cr-Commit-Position: refs/heads/master@{#12800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -576 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/video_coding/frame_buffer2.h View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/modules/video_coding/frame_buffer2.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D webrtc/modules/video_coding/frame_buffer2_unittest.cc View 1 chunk +0 lines, -329 lines 0 comments Download
M webrtc/modules/video_coding/frame_object.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_object.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/timing.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
honghaiz3
Created Revert of FrameBuffer for the new jitter buffer.
4 years, 7 months ago (2016-05-18 22:52:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991513004/1
4 years, 7 months ago (2016-05-18 22:52:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 22:52:32 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 22:52:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b711f10d9683b9de6ee78186f77b225fc7ebfb8f
Cr-Commit-Position: refs/heads/master@{#12800}

Powered by Google App Engine
This is Rietveld 408576698