webrtc/voice_engine/channel_proxy.h - Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/channel_proxy.h

Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-injections-3

Patch Set: Removed explicit constructor qualifier. Fixed comment grammar. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/voice_engine/channel_proxy.h

diff --git a/webrtc/voice_engine/channel_proxy.h b/webrtc/voice_engine/channel_proxy.h

index df0c3f22ef67cd0c5bf2d2ab34f92cd47c8a7751..e2d78b7ea1ac4b5a81a163e9bb9a00298439fb64 100644

--- a/webrtc/voice_engine/channel_proxy.h

+++ b/webrtc/voice_engine/channel_proxy.h

@@ -80,6 +80,7 @@ class ChannelProxy {

const PacketTime& packet_time);

virtual bool ReceivedRTCPPacket(const uint8_t* packet, size_t length);

+ const rtc::scoped_refptr<AudioDecoderFactory>& GetAudioDecoderFactory() const;

the sun 2016/05/30 19:09:53 virtual - this class should be fully mockable.

ossu 2016/06/02 15:47:47 Oh, right!

private:

Channel* channel() const;

« webrtc/voice_engine/channel.cc ('K') | « webrtc/voice_engine/channel.cc ('k') | webrtc/voice_engine/channel_proxy.cc » ('j') | no next file with comments »