Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: webrtc/voice_engine/channel_proxy.h

Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-injections-3
Patch Set: Removed explicit constructor qualifier. Fixed comment grammar. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 virtual bool SendTelephoneEventOutband(int event, int duration_ms); 73 virtual bool SendTelephoneEventOutband(int event, int duration_ms);
74 virtual void SetSink(std::unique_ptr<AudioSinkInterface> sink); 74 virtual void SetSink(std::unique_ptr<AudioSinkInterface> sink);
75 75
76 virtual void RegisterExternalTransport(Transport* transport); 76 virtual void RegisterExternalTransport(Transport* transport);
77 virtual void DeRegisterExternalTransport(); 77 virtual void DeRegisterExternalTransport();
78 virtual bool ReceivedRTPPacket(const uint8_t* packet, 78 virtual bool ReceivedRTPPacket(const uint8_t* packet,
79 size_t length, 79 size_t length,
80 const PacketTime& packet_time); 80 const PacketTime& packet_time);
81 virtual bool ReceivedRTCPPacket(const uint8_t* packet, size_t length); 81 virtual bool ReceivedRTCPPacket(const uint8_t* packet, size_t length);
82 82
83 const rtc::scoped_refptr<AudioDecoderFactory>& GetAudioDecoderFactory() const;
the sun 2016/05/30 19:09:53 virtual - this class should be fully mockable.
ossu 2016/06/02 15:47:47 Oh, right!
83 private: 84 private:
84 Channel* channel() const; 85 Channel* channel() const;
85 86
86 rtc::ThreadChecker thread_checker_; 87 rtc::ThreadChecker thread_checker_;
87 ChannelOwner channel_owner_; 88 ChannelOwner channel_owner_;
88 89
89 RTC_DISALLOW_COPY_AND_ASSIGN(ChannelProxy); 90 RTC_DISALLOW_COPY_AND_ASSIGN(ChannelProxy);
90 }; 91 };
91 } // namespace voe 92 } // namespace voe
92 } // namespace webrtc 93 } // namespace webrtc
93 94
94 #endif // WEBRTC_VOICE_ENGINE_CHANNEL_PROXY_H_ 95 #endif // WEBRTC_VOICE_ENGINE_CHANNEL_PROXY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698