Propagate muted parameter to VoE::Channel

Propagate muted parameter to VoE::Channel

Deleted the temporary ACM method without the muted parameter, and had
to modify several tests for this. The muted parameter is not yet propagated to the AudioConferenceMixer; this is the next step.

BUG=webrtc:5609
TBR=perkj@webrtc.org

Committed: https://crrev.com/d4ccb00b9e636cc8b4297db5555654b2546681e0
Cr-Commit-Position: refs/heads/master@{#12779}

[hlundin-webrtc, 2016-05-16 15:30:18]

henrik.lundin@webrtc.org changed reviewers:
+ henrika@webrtc.org, minyue@webrtc.org, perkj@webrtc.org

[hlundin-webrtc, 2016-05-16 15:30:19]

Please, review this CL.

henrika@: webrtc/voice_engine/channel.cc
perkj@: webrtc/modules/utility/source/coder.cc
minyue@: webrtc/modules/audio_coding/*

Thanks!

[henrika_webrtc, 2016-05-16 15:35:06]

LGTM

[minyue-webrtc, 2016-05-17 02:20:57]

good work!

lg + some comments

https://codereview.webrtc.org/1985743002/diff/1/webrtc/modules/audio_coding/t...
File webrtc/modules/audio_coding/test/TestStereo.cc (right):

https://codereview.webrtc.org/1985743002/diff/1/webrtc/modules/audio_coding/t...
webrtc/modules/audio_coding/test/TestStereo.cc:797: RTC_DCHECK(!muted);
why not ASSERT?

https://codereview.webrtc.org/1985743002/diff/1/webrtc/modules/utility/source...
File webrtc/modules/utility/source/coder.cc (right):

https://codereview.webrtc.org/1985743002/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/coder.cc:20:
RTC_DCHECK(!config.neteq_config.enable_fast_accelerate);
fast_accelerate or muted states?

why not setting it to false then

https://codereview.webrtc.org/1985743002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/1985743002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:816:
RTC_DCHECK(!acm_config.neteq_config.enable_muted_state);
why not setting it to false then?

[hlundin-webrtc, 2016-05-17 06:37:37]

Fixing review comments

[hlundin-webrtc, 2016-05-17 07:12:04]

Resurrect the PlayoutData10Ms(int, AudioFrame*) method

[hlundin-webrtc, 2016-05-17 07:18:44]

Thanks!

Minyue, PTAL again. In PS#2, I address your comments. In PS#3, I put back the
ACM methods that I removed in the first PS; PlayoutData10Ms(int, AudioFrame)
without the muted parameter. The reason is that I do not want to have this CL
reverted just because I happen to break any unforeseen downstream dependencies,
so close to the cut. The methods will still be removed, but not right now.

https://codereview.webrtc.org/1985743002/diff/1/webrtc/modules/audio_coding/t...
File webrtc/modules/audio_coding/test/TestStereo.cc (right):

https://codereview.webrtc.org/1985743002/diff/1/webrtc/modules/audio_coding/t...
webrtc/modules/audio_coding/test/TestStereo.cc:797: RTC_DCHECK(!muted);
On 2016/05/17 02:20:57, minyue-webrtc wrote:
> why not ASSERT?

Good point. Done.

https://codereview.webrtc.org/1985743002/diff/1/webrtc/modules/utility/source...
File webrtc/modules/utility/source/coder.cc (right):

https://codereview.webrtc.org/1985743002/diff/1/webrtc/modules/utility/source...
webrtc/modules/utility/source/coder.cc:20:
RTC_DCHECK(!config.neteq_config.enable_fast_accelerate);
On 2016/05/17 02:20:57, minyue-webrtc wrote:
> fast_accelerate or muted states?
> 
> why not setting it to false then

Excellent point. And thanks for finding the error. Done!

Since I've already made this mistake twice, I searched the codebase for
enable_fast_accelerate, but all remaining uses are legit.

https://codereview.webrtc.org/1985743002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/1985743002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:816:
RTC_DCHECK(!acm_config.neteq_config.enable_muted_state);
On 2016/05/17 02:20:57, minyue-webrtc wrote:
> why not setting it to false then?

Done.

[hlundin-webrtc, 2016-05-17 13:18:00]

The CQ bit was checked by henrik.lundin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 13:18:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985743002/40001

[minyue-webrtc, 2016-05-17 15:16:37]

lgtm

[commit-bot: I haz the power, 2016-05-17 15:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 15:18:37]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hlundin-webrtc, 2016-05-17 19:16:41]

Description was changed from

==========
Propagate muted parameter to VoE::Channel

Deleted the temporary ACM method without the muted parameter, and had
to modify several tests for this. The muted parameter is not yet propagated to
the AudioConferenceMixer; this is the next step.

BUG=webrtc:5609
==========

to

==========
Propagate muted parameter to VoE::Channel

Deleted the temporary ACM method without the muted parameter, and had
to modify several tests for this. The muted parameter is not yet propagated to
the AudioConferenceMixer; this is the next step.

BUG=webrtc:5609
TBR=perkj@webrtc.org
==========

[hlundin-webrtc, 2016-05-17 19:16:50]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-05-17 19:16:50]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1985743002/#ps40001 (title:
"Resurrect the PlayoutData10Ms(int, AudioFrame*) method")

[commit-bot: I haz the power, 2016-05-17 19:16:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985743002/40001

[commit-bot: I haz the power, 2016-05-17 19:22:01]

Description was changed from

==========
Propagate muted parameter to VoE::Channel

Deleted the temporary ACM method without the muted parameter, and had
to modify several tests for this. The muted parameter is not yet propagated to
the AudioConferenceMixer; this is the next step.

BUG=webrtc:5609
TBR=perkj@webrtc.org
==========

to

==========
Propagate muted parameter to VoE::Channel

Deleted the temporary ACM method without the muted parameter, and had
to modify several tests for this. The muted parameter is not yet propagated to
the AudioConferenceMixer; this is the next step.

BUG=webrtc:5609
TBR=perkj@webrtc.org
==========

[commit-bot: I haz the power, 2016-05-17 19:22:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-17 19:22:10]

Description was changed from

==========
Propagate muted parameter to VoE::Channel

Deleted the temporary ACM method without the muted parameter, and had
to modify several tests for this. The muted parameter is not yet propagated to
the AudioConferenceMixer; this is the next step.

BUG=webrtc:5609
TBR=perkj@webrtc.org
==========

to

==========
Propagate muted parameter to VoE::Channel

Deleted the temporary ACM method without the muted parameter, and had
to modify several tests for this. The muted parameter is not yet propagated to
the AudioConferenceMixer; this is the next step.

BUG=webrtc:5609
TBR=perkj@webrtc.org

Committed: https://crrev.com/d4ccb00b9e636cc8b4297db5555654b2546681e0
Cr-Commit-Position: refs/heads/master@{#12779}
==========

[commit-bot: I haz the power, 2016-05-17 19:22:11]

Patchset 3 (id:??) landed as
https://crrev.com/d4ccb00b9e636cc8b4297db5555654b2546681e0
Cr-Commit-Position: refs/heads/master@{#12779}