Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1981243002: AudioConfMixer: Add muted variable to ParticipantFramePair (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@muted-in-voe
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

AudioConfMixer: Add muted variable to ParticipantFramePair Renaming the ParticipantFramePair to ParticipantFrameStruct. The muted variable is not yet used. BUG=webrtc:5609 Committed: https://crrev.com/3a0a0f4b0dae11b20ebacdbd79d6c7f94edeac7b Cr-Commit-Position: refs/heads/master@{#12780}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc View 5 chunks +15 lines, -14 lines 2 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
hlundin-webrtc
Minyue, PTAL at this change.
4 years, 7 months ago (2016-05-17 10:25:02 UTC) #2
minyue-webrtc
LGTM + one question (no action needed) https://codereview.webrtc.org/1981243002/diff/1/webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc File webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc (right): https://codereview.webrtc.org/1981243002/diff/1/webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc#newcode26 webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc:26: AudioFrame* audioFrame; ...
4 years, 7 months ago (2016-05-17 15:27:30 UTC) #3
hlundin-webrtc
https://codereview.webrtc.org/1981243002/diff/1/webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc File webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc (right): https://codereview.webrtc.org/1981243002/diff/1/webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc#newcode26 webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc:26: AudioFrame* audioFrame; On 2016/05/17 15:27:30, minyue-webrtc wrote: > I ...
4 years, 7 months ago (2016-05-17 18:09:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981243002/1
4 years, 7 months ago (2016-05-17 19:24:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-17 21:25:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981243002/1
4 years, 7 months ago (2016-05-18 00:14:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 00:16:01 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 00:16:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a0a0f4b0dae11b20ebacdbd79d6c7f94edeac7b
Cr-Commit-Position: refs/heads/master@{#12780}

Powered by Google App Engine
This is Rietveld 408576698