Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1984243003: Set ViEEncoder sink_ on construction. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set ViEEncoder sink_ on construction. Removes sink_crit_ and makes sink_ const. webrtc:5687 R=perkj@webrtc.org Committed: https://crrev.com/00b9d210c4b15f66942691efe577d701e9c99e7f Cr-Commit-Position: refs/heads/master@{#12813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M webrtc/call/bitrate_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/encoder_state_feedback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/vie_encoder.h View 4 chunks +5 lines, -6 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 4 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pbos-webrtc
PTAL
4 years, 7 months ago (2016-05-17 15:46:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984243003/1
4 years, 7 months ago (2016-05-17 15:47:54 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-17 17:48:23 UTC) #5
perkj_webrtc
Please refer to BUG=webrtc:5687 lgtm and thanks.
4 years, 7 months ago (2016-05-19 14:43:54 UTC) #6
pbos-webrtc
4 years, 7 months ago (2016-05-19 14:59:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00b9d210c4b15f66942691efe577d701e9c99e7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698