Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: webrtc/video/vie_encoder.h

Issue 1984243003: Set ViEEncoder sink_ on construction. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_encoder.h
diff --git a/webrtc/video/vie_encoder.h b/webrtc/video/vie_encoder.h
index 556ed449955d4819fab7206691b7d8f06ca63751..212962348ad7a110c24a3060437fe7c320e1531e 100644
--- a/webrtc/video/vie_encoder.h
+++ b/webrtc/video/vie_encoder.h
@@ -58,7 +58,9 @@ class ViEEncoder : public VideoEncoderRateObserver,
ViEEncoder(uint32_t number_of_cores,
ProcessThread* module_process_thread,
SendStatisticsProxy* stats_proxy,
- OveruseFrameDetector* overuse_detector);
+ OveruseFrameDetector* overuse_detector,
+ EncodedImageCallback* sink);
+
~ViEEncoder();
vcm::VideoSender* video_sender();
@@ -77,8 +79,7 @@ class ViEEncoder : public VideoEncoderRateObserver,
int32_t DeRegisterExternalEncoder(uint8_t pl_type);
void SetEncoder(const VideoCodec& video_codec,
int min_transmit_bitrate_bps,
- size_t max_data_payload_length,
- EncodedImageCallback* sink);
+ size_t max_data_payload_length);
void EncodeVideoFrame(const VideoFrame& video_frame);
void SendKeyFrame();
@@ -119,6 +120,7 @@ class ViEEncoder : public VideoEncoderRateObserver,
void TraceFrameDropEnd() EXCLUSIVE_LOCKS_REQUIRED(data_cs_);
const uint32_t number_of_cores_;
+ EncodedImageCallback* const sink_;
const std::unique_ptr<VideoProcessing> vp_;
vcm::VideoSender video_sender_;
@@ -138,9 +140,6 @@ class ViEEncoder : public VideoEncoderRateObserver,
bool encoder_paused_ GUARDED_BY(data_cs_);
bool encoder_paused_and_dropped_frame_ GUARDED_BY(data_cs_);
- rtc::CriticalSection sink_cs_;
- EncodedImageCallback* sink_ GUARDED_BY(sink_cs_);
-
ProcessThread* module_process_thread_;
bool has_received_sli_ GUARDED_BY(data_cs_);
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698