webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm - Issue 1978233002: Polishing code to handle certificate generation failure in .mm files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm

Issue 1978233002: Polishing code to handle certificate generation failure in .mm files. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm

diff --git a/webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm b/webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm

index 9dec1152108ee9a293fb798554957e1954a771a5..f565adbefd0388310b5b2eaa9f414cf22ad26a22 100644

--- a/webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm

+++ b/webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm

@@ -45,7 +45,8 @@

RTCContinualGatheringPolicyGatherContinually;

std::unique_ptr<webrtc::PeerConnectionInterface::RTCConfiguration>

- nativeConfig(config.nativeConfiguration);

+ nativeConfig([config createNativeConfiguration]);

+ EXPECT_TRUE(nativeConfig.get());

EXPECT_EQ(1u, nativeConfig->servers.size());

webrtc::PeerConnectionInterface::IceServer nativeServer =

nativeConfig->servers.front();

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm ('k') | no next file » | no next file with comments »