Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm

Issue 1978233002: Polishing code to handle certificate generation failure in .mm files. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 27 matching lines...) Expand all
38 const int maxPackets = 60; 38 const int maxPackets = 60;
39 const int timeout = 1; 39 const int timeout = 1;
40 const int interval = 2; 40 const int interval = 2;
41 config.audioJitterBufferMaxPackets = maxPackets; 41 config.audioJitterBufferMaxPackets = maxPackets;
42 config.iceConnectionReceivingTimeout = timeout; 42 config.iceConnectionReceivingTimeout = timeout;
43 config.iceBackupCandidatePairPingInterval = interval; 43 config.iceBackupCandidatePairPingInterval = interval;
44 config.continualGatheringPolicy = 44 config.continualGatheringPolicy =
45 RTCContinualGatheringPolicyGatherContinually; 45 RTCContinualGatheringPolicyGatherContinually;
46 46
47 std::unique_ptr<webrtc::PeerConnectionInterface::RTCConfiguration> 47 std::unique_ptr<webrtc::PeerConnectionInterface::RTCConfiguration>
48 nativeConfig(config.nativeConfiguration); 48 nativeConfig([config createNativeConfiguration]);
49 EXPECT_TRUE(nativeConfig.get());
49 EXPECT_EQ(1u, nativeConfig->servers.size()); 50 EXPECT_EQ(1u, nativeConfig->servers.size());
50 webrtc::PeerConnectionInterface::IceServer nativeServer = 51 webrtc::PeerConnectionInterface::IceServer nativeServer =
51 nativeConfig->servers.front(); 52 nativeConfig->servers.front();
52 EXPECT_EQ(1u, nativeServer.urls.size()); 53 EXPECT_EQ(1u, nativeServer.urls.size());
53 EXPECT_EQ("stun:stun1.example.net", nativeServer.urls.front()); 54 EXPECT_EQ("stun:stun1.example.net", nativeServer.urls.front());
54 55
55 EXPECT_EQ(webrtc::PeerConnectionInterface::kRelay, nativeConfig->type); 56 EXPECT_EQ(webrtc::PeerConnectionInterface::kRelay, nativeConfig->type);
56 EXPECT_EQ(webrtc::PeerConnectionInterface::kBundlePolicyMaxBundle, 57 EXPECT_EQ(webrtc::PeerConnectionInterface::kBundlePolicyMaxBundle,
57 nativeConfig->bundle_policy); 58 nativeConfig->bundle_policy);
58 EXPECT_EQ(webrtc::PeerConnectionInterface::kRtcpMuxPolicyNegotiate, 59 EXPECT_EQ(webrtc::PeerConnectionInterface::kRtcpMuxPolicyNegotiate,
59 nativeConfig->rtcp_mux_policy); 60 nativeConfig->rtcp_mux_policy);
60 EXPECT_EQ(webrtc::PeerConnectionInterface::kTcpCandidatePolicyDisabled, 61 EXPECT_EQ(webrtc::PeerConnectionInterface::kTcpCandidatePolicyDisabled,
61 nativeConfig->tcp_candidate_policy); 62 nativeConfig->tcp_candidate_policy);
62 EXPECT_EQ(maxPackets, nativeConfig->audio_jitter_buffer_max_packets); 63 EXPECT_EQ(maxPackets, nativeConfig->audio_jitter_buffer_max_packets);
63 EXPECT_EQ(timeout, nativeConfig->ice_connection_receiving_timeout); 64 EXPECT_EQ(timeout, nativeConfig->ice_connection_receiving_timeout);
64 EXPECT_EQ(interval, nativeConfig->ice_backup_candidate_pair_ping_interval); 65 EXPECT_EQ(interval, nativeConfig->ice_backup_candidate_pair_ping_interval);
65 EXPECT_EQ(webrtc::PeerConnectionInterface::GATHER_CONTINUALLY, 66 EXPECT_EQ(webrtc::PeerConnectionInterface::GATHER_CONTINUALLY,
66 nativeConfig->continual_gathering_policy); 67 nativeConfig->continual_gathering_policy);
67 } 68 }
68 69
69 @end 70 @end
70 71
71 TEST(RTCConfigurationTest, NativeConfigurationConversionTest) { 72 TEST(RTCConfigurationTest, NativeConfigurationConversionTest) {
72 @autoreleasepool { 73 @autoreleasepool {
73 RTCConfigurationTest *test = [[RTCConfigurationTest alloc] init]; 74 RTCConfigurationTest *test = [[RTCConfigurationTest alloc] init];
74 [test testConversionToNativeConfiguration]; 75 [test testConversionToNativeConfiguration];
75 } 76 }
76 } 77 }
77 78
OLDNEW
« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698