Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: webrtc/modules/video_coding/video_sender_unittest.cc

Issue 1972183004: Reland "Remove ViEEncoder::SetNetworkStatus" (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/video_sender_unittest.cc
diff --git a/webrtc/modules/video_coding/video_sender_unittest.cc b/webrtc/modules/video_coding/video_sender_unittest.cc
index a9c67909d1a9ff40ef0265dbf166e114866ef9d2..5324ceeb0b8f5078a8c4849fbe1de975b562a2e4 100644
--- a/webrtc/modules/video_coding/video_sender_unittest.cc
+++ b/webrtc/modules/video_coding/video_sender_unittest.cc
@@ -292,6 +292,18 @@ TEST_F(TestVideoSenderWithMockEncoder, TestIntraRequests) {
AddFrame();
}
+TEST_F(TestVideoSenderWithMockEncoder, TestSetRate) {
+ const uint32_t new_bitrate = settings_.startBitrate + 300;
+ EXPECT_CALL(encoder_, SetRates(new_bitrate, _)).Times(1).WillOnce(Return(0));
+ sender_->SetChannelParameters(new_bitrate * 1000, 0, 200);
+ AddFrame();
+
+ // Expect no call to encoder_.SetRates if the new bitrate is zero.
+ EXPECT_CALL(encoder_, SetRates(new_bitrate, _)).Times(0);
+ sender_->SetChannelParameters(0, 0, 200);
+ AddFrame();
+}
+
TEST_F(TestVideoSenderWithMockEncoder, TestIntraRequestsInternalCapture) {
// De-register current external encoder.
sender_->RegisterExternalEncoder(nullptr, kUnusedPayloadType, false);

Powered by Google App Engine
This is Rietveld 408576698