Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Unified Diff: webrtc/modules/video_coding/video_sender.cc

Issue 1972183004: Reland "Remove ViEEncoder::SetNetworkStatus" (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/video_sender.cc
diff --git a/webrtc/modules/video_coding/video_sender.cc b/webrtc/modules/video_coding/video_sender.cc
index a3a4d6d6c86b1b7e2a46885c7dabcf2695f1c51f..d772c94123eea917af5f57b9a2b3b681ec313fe4 100644
--- a/webrtc/modules/video_coding/video_sender.cc
+++ b/webrtc/modules/video_coding/video_sender.cc
@@ -228,6 +228,10 @@ int32_t VideoSender::SetChannelParameters(uint32_t target_bitrate,
}
void VideoSender::SetEncoderParameters(EncoderParameters params) {
+ // |target_bitrate == 0 | means that the network is down or the send pacer is
+ // full.
+ // TODO(perkj): Consider setting |target_bitrate| == 0 to the encoders.
+ // especially if |encoder_has_internal_source_ | == true.
stefan-webrtc 2016/05/13 12:33:55 Especially
perkj_webrtc 2016/05/13 13:03:28 Done.
if (params.target_bitrate == 0)
return;

Powered by Google App Engine
This is Rietveld 408576698