Reland "Remove ViEEncoder::SetNetworkStatus"

This reland https://codereview.webrtc.org/1932683002/.
Remove ViEEncoder::SetNetworkStatus.

Original cl description:
This cl removed ViEEncoder::SetNetworkStatus. Instead the PacedSender will report that frames can not be sent when the network is down and the BitrateController will report an estimated available bandwidth of 0 bps.

Patchset #1 is a pure reland.
Patchset #2 change the bitrate allocator to always return an initial bitrate >0 regardless of the estimates. The observer will be notified though if the network is down.

BUG=webrtc:5687
Committed: https://crrev.com/fea93099f02bcde7ac3b4b245f1b64cffed1b839
Cr-Commit-Position: refs/heads/master@{#12743}

[perkj_webrtc, 2016-05-13 12:18:23]

Description was changed from

==========
Revert "Revert of Remove ViEEncoder::SetNetworkStatus (patchset #11 id:200001 of
https://codereview.webrtc.org/1932683002/ )"

This reverts commit 7339c500fe5dec689e69a6cfc745f2508cbcdedf.

BUG=
==========

to

==========
This reland https://codereview.webrtc.org/1932683002/.
Remove ViEEncoder::SetNetworkStatus.

Original cl description:
This cl removed ViEEncoder::SetNetworkStatus. Instead the PacedSender will
report that frames can not be sent when the network is down and the
BitrateController will report an estimated available bandwidth of 0 bps.

Patchset #1 is a pure reland.
Patchset #2 change the bitrate allocator to always return an initial bitrate >0
regardless of the estimates. The observer will be notified though if the network
is down.




BUG=webrtc:5687
==========

[perkj_webrtc, 2016-05-13 12:18:24]

perkj@webrtc.org changed reviewers:
+ stefan@webrtc.org

[perkj_webrtc, 2016-05-13 12:24:19]

PTAL

[stefan-webrtc, 2016-05-13 12:33:55]

Nice, lgtm

https://codereview.webrtc.org/1972183004/diff/40001/webrtc/call/bitrate_alloc...
File webrtc/call/bitrate_allocator.h (right):

https://codereview.webrtc.org/1972183004/diff/40001/webrtc/call/bitrate_alloc...
webrtc/call/bitrate_allocator.h:118: uint32_t last_none_zero_bitrate_bps_
GUARDED_BY(crit_sect_);
non_zero

https://codereview.webrtc.org/1972183004/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_sender.cc (right):

https://codereview.webrtc.org/1972183004/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_sender.cc:234: // especially if
|encoder_has_internal_source_ | == true.
Especially

[perkj_webrtc, 2016-05-13 13:03:29]

https://codereview.webrtc.org/1972183004/diff/40001/webrtc/call/bitrate_alloc...
File webrtc/call/bitrate_allocator.h (right):

https://codereview.webrtc.org/1972183004/diff/40001/webrtc/call/bitrate_alloc...
webrtc/call/bitrate_allocator.h:118: uint32_t last_none_zero_bitrate_bps_
GUARDED_BY(crit_sect_);
On 2016/05/13 12:33:55, stefan-webrtc (holmer) wrote:
> non_zero

Done.

https://codereview.webrtc.org/1972183004/diff/40001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_sender.cc (right):

https://codereview.webrtc.org/1972183004/diff/40001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_sender.cc:234: // especially if
|encoder_has_internal_source_ | == true.
On 2016/05/13 12:33:55, stefan-webrtc (holmer) wrote:
> Especially

Done.

[perkj_webrtc, 2016-05-13 13:03:33]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-05-13 13:03:34]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1972183004/#ps60001 (title:
"Addressed comments.")

[commit-bot: I haz the power, 2016-05-13 13:03:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972183004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972183004/60001

[commit-bot: I haz the power, 2016-05-13 13:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 13:13:35]

Try jobs failed on following builders:
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/15087)

[perkj_webrtc, 2016-05-14 07:42:02]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-05-14 07:42:02]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1972183004/#ps80001 (title:
"Fix bug in BitrateAllocator::Allocate(bitrate)")

[commit-bot: I haz the power, 2016-05-14 07:42:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972183004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972183004/80001

[commit-bot: I haz the power, 2016-05-14 07:58:51]

Description was changed from

==========
This reland https://codereview.webrtc.org/1932683002/.
Remove ViEEncoder::SetNetworkStatus.

Original cl description:
This cl removed ViEEncoder::SetNetworkStatus. Instead the PacedSender will
report that frames can not be sent when the network is down and the
BitrateController will report an estimated available bandwidth of 0 bps.

Patchset #1 is a pure reland.
Patchset #2 change the bitrate allocator to always return an initial bitrate >0
regardless of the estimates. The observer will be notified though if the network
is down.




BUG=webrtc:5687
==========

to

==========
This reland https://codereview.webrtc.org/1932683002/.
Remove ViEEncoder::SetNetworkStatus.

Original cl description:
This cl removed ViEEncoder::SetNetworkStatus. Instead the PacedSender will
report that frames can not be sent when the network is down and the
BitrateController will report an estimated available bandwidth of 0 bps.

Patchset #1 is a pure reland.
Patchset #2 change the bitrate allocator to always return an initial bitrate >0
regardless of the estimates. The observer will be notified though if the network
is down.




BUG=webrtc:5687
==========

[commit-bot: I haz the power, 2016-05-14 07:58:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-14 07:59:01]

Description was changed from

==========
This reland https://codereview.webrtc.org/1932683002/.
Remove ViEEncoder::SetNetworkStatus.

Original cl description:
This cl removed ViEEncoder::SetNetworkStatus. Instead the PacedSender will
report that frames can not be sent when the network is down and the
BitrateController will report an estimated available bandwidth of 0 bps.

Patchset #1 is a pure reland.
Patchset #2 change the bitrate allocator to always return an initial bitrate >0
regardless of the estimates. The observer will be notified though if the network
is down.




BUG=webrtc:5687
==========

to

==========
This reland https://codereview.webrtc.org/1932683002/.
Remove ViEEncoder::SetNetworkStatus.

Original cl description:
This cl removed ViEEncoder::SetNetworkStatus. Instead the PacedSender will
report that frames can not be sent when the network is down and the
BitrateController will report an estimated available bandwidth of 0 bps.

Patchset #1 is a pure reland.
Patchset #2 change the bitrate allocator to always return an initial bitrate >0
regardless of the estimates. The observer will be notified though if the network
is down.

BUG=webrtc:5687

Committed: https://crrev.com/fea93099f02bcde7ac3b4b245f1b64cffed1b839
Cr-Commit-Position: refs/heads/master@{#12743}
==========

[commit-bot: I haz the power, 2016-05-14 07:59:02]

Patchset 5 (id:??) landed as
https://crrev.com/fea93099f02bcde7ac3b4b245f1b64cffed1b839
Cr-Commit-Position: refs/heads/master@{#12743}