webrtc/modules/video_coding/video_sender.cc - Issue 1972183004: Reland "Remove ViEEncoder::SetNetworkStatus"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/video_sender.cc

Issue 1972183004: Reland "Remove ViEEncoder::SetNetworkStatus" (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix bug in BitrateAllocator::Allocate(bitrate) Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/video_sender.cc

diff --git a/webrtc/modules/video_coding/video_sender.cc b/webrtc/modules/video_coding/video_sender.cc

index a3a4d6d6c86b1b7e2a46885c7dabcf2695f1c51f..f52b1c56e7b550127507610f1696becdf73de699 100644

--- a/webrtc/modules/video_coding/video_sender.cc

+++ b/webrtc/modules/video_coding/video_sender.cc

@@ -228,6 +228,10 @@ int32_t VideoSender::SetChannelParameters(uint32_t target_bitrate,

}

void VideoSender::SetEncoderParameters(EncoderParameters params) {

+ // |target_bitrate == 0 | means that the network is down or the send pacer is

+ // full.

+ // TODO(perkj): Consider setting |target_bitrate| == 0 to the encoders.

+ // Especially if |encoder_has_internal_source_ | == true.

if (params.target_bitrate == 0)

return;