Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1971693003: Clamp number of downscales in QualityScaler. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clamp number of downscales in QualityScaler. Fixes bug where QualityScaler would be stuck "way below" QVGA (due to downscale_shift_) even though it would never scale below QVGA. Also fixes issue where samples would be cleared when either staying at max resolution or going below QVGA even though no action happened. BUG= R=glaznev@webrtc.org Committed: https://crrev.com/919288f6ba4ac2112c616c877273e84374904da9 Cr-Commit-Position: refs/heads/master@{#12691}

Patch Set 1 #

Patch Set 2 : zero out initial resolution #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M webrtc/modules/video_coding/utility/quality_scaler.cc View 1 3 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pbos-webrtc
PTAL
4 years, 7 months ago (2016-05-11 21:13:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971693003/1
4 years, 7 months ago (2016-05-11 21:13:18 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/9998)
4 years, 7 months ago (2016-05-11 21:49:10 UTC) #5
pbos-webrtc
zero out initial resolution
4 years, 7 months ago (2016-05-11 22:08:08 UTC) #6
pbos-webrtc
this should've covered the bot failure
4 years, 7 months ago (2016-05-11 22:17:14 UTC) #7
AlexG
lgtm
4 years, 7 months ago (2016-05-11 23:51:38 UTC) #8
pbos-webrtc
4 years, 7 months ago (2016-05-12 00:18:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
919288f6ba4ac2112c616c877273e84374904da9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698