Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1971563002: Add config continualGatheringPolicy to the IOS RTCConfiguration. (Closed)

Created:
4 years, 7 months ago by honghaiz3
Modified:
4 years, 7 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add config continualGatheringPolicy to the IOS RTCConfiguration. BUG= R=tkchin@webrtc.org Committed: https://crrev.com/3108fc933b7dfacf3b724e4b956b99f6575696bc Cr-Commit-Position: refs/heads/master@{#12689}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Merge with head #

Patch Set 3 : address comments #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm View 1 2 3 5 chunks +41 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
honghaiz3
Please take a look at the CL.
4 years, 7 months ago (2016-05-10 21:56:05 UTC) #2
tkchin_webrtc
lgtm https://codereview.webrtc.org/1971563002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm File webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm (right): https://codereview.webrtc.org/1971563002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm#newcode47 webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm:47: _continualGatheringPolicy = nit: if it doesn't fit, put ...
4 years, 7 months ago (2016-05-10 23:00:35 UTC) #3
tkchin_webrtc
as a nit: this doesn't actually affect AppRTCDemo update title to something like Add continualGatheringPolicy ...
4 years, 7 months ago (2016-05-10 23:01:13 UTC) #4
honghaiz3
Thanks! https://codereview.webrtc.org/1971563002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm File webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm (right): https://codereview.webrtc.org/1971563002/diff/1/webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm#newcode47 webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm:47: _continualGatheringPolicy = On 2016/05/10 23:00:35, tkchin_webrtc wrote: > ...
4 years, 7 months ago (2016-05-10 23:26:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971563002/40001
4 years, 7 months ago (2016-05-10 23:28:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3879)
4 years, 7 months ago (2016-05-10 23:35:12 UTC) #11
tkchin_webrtc
https://codereview.webrtc.org/1971563002/diff/40001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h (right): https://codereview.webrtc.org/1971563002/diff/40001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h#newcode49 webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:49: RTCGatherOnce, actually I missed this sorry RTCContinualGatheringPolicyGatherOnce RTCContinualGatheringPolicyGatherContinually
4 years, 7 months ago (2016-05-10 23:47:35 UTC) #12
honghaiz3
https://codereview.webrtc.org/1971563002/diff/40001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h (right): https://codereview.webrtc.org/1971563002/diff/40001/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h#newcode49 webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:49: RTCGatherOnce, On 2016/05/10 23:47:35, tkchin_webrtc wrote: > actually I ...
4 years, 7 months ago (2016-05-11 00:02:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971563002/60001
4 years, 7 months ago (2016-05-11 00:02:40 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3881)
4 years, 7 months ago (2016-05-11 00:09:53 UTC) #18
honghaiz3
4 years, 7 months ago (2016-05-11 17:10:53 UTC) #20
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
3108fc933b7dfacf3b724e4b956b99f6575696bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698