Propogate network-worker thread split to api

Propogate network-worker thread split to api

BUG=webrtc:5645
Committed: https://crrev.com/e9021a3601eff3e33a103ae35fb866554ee28747
Cr-Commit-Position: refs/heads/master@{#12767}

[danilchap, 2016-05-12 16:00:37]

danilchap@webrtc.org changed reviewers:
+ magjed@webrtc.org, pthatcher@webrtc.org, tkchin@webrtc.org

[danilchap, 2016-05-12 16:00:37]

magjed@ can you please check java/android changes.
tkchin@ can you review ios/mac changes.

this CL propagate and activates network thread that might be different from
worker thread.

Because network thread should match thread used by probably external
PortAllocator, network thread propogated all the way to
CreatePeerConnectionFactory.

[magjed_webrtc, 2016-05-13 11:33:29]

https://codereview.webrtc.org/1968393002/diff/140001/webrtc/api/java/jni/peer...
File webrtc/api/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1968393002/diff/140001/webrtc/api/java/jni/peer...
webrtc/api/java/jni/peerconnection_jni.cc:1090: m = GetStaticMethodID(jni,
j_factory_class, "onNetworkThreadReady", "()V");
You need to add the java function onNetworkThreadReady in
PeerConnectionFactory.java. Please send for review once all tests succeed.

[danilchap, 2016-05-13 16:40:31]

https://codereview.webrtc.org/1968393002/diff/140001/webrtc/api/java/jni/peer...
File webrtc/api/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1968393002/diff/140001/webrtc/api/java/jni/peer...
webrtc/api/java/jni/peerconnection_jni.cc:1090: m = GetStaticMethodID(jni,
j_factory_class, "onNetworkThreadReady", "()V");
On 2016/05/13 11:33:29, magjed_webrtc wrote:
> You need to add the java function onNetworkThreadReady in
> PeerConnectionFactory.java. 

Done, btw, am I right this is only used to generate a more verbose stack trace
in case of an exception?
May be no need to expose all this three threads for that? 

> Please send for review once all tests succeed.
Done.

[pthatcher1, 2016-05-13 18:32:50]

lgtm, with nits

https://codereview.webrtc.org/1968393002/diff/180001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/1968393002/diff/180001/webrtc/pc/channel.cc#new...
webrtc/pc/channel.cc:209:
DisconnectFromTransportChannel(rtcp_transport_channel_);
{}s please

https://codereview.webrtc.org/1968393002/diff/180001/webrtc/pc/channel.cc#new...
webrtc/pc/channel.cc:261: // Packets arrive on network thread, processing
packets calls virtual
on network thread -> on the network thread

[magjed_webrtc, 2016-05-16 09:59:34]

java/android changes lgtm

https://codereview.webrtc.org/1968393002/diff/140001/webrtc/api/java/jni/peer...
File webrtc/api/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1968393002/diff/140001/webrtc/api/java/jni/peer...
webrtc/api/java/jni/peerconnection_jni.cc:1090: m = GetStaticMethodID(jni,
j_factory_class, "onNetworkThreadReady", "()V");
On 2016/05/13 16:40:31, danilchap wrote:
> On 2016/05/13 11:33:29, magjed_webrtc wrote:
> > You need to add the java function onNetworkThreadReady in
> > PeerConnectionFactory.java. 
> 
> Done, btw, am I right this is only used to generate a more verbose stack trace
> in case of an exception?
> May be no need to expose all this three threads for that? 

It was added in CL "Add option to print peer connection factory Java stack
traces." https://codereview.webrtc.org/1395693002/. I guess it's best to print
the stack trace for all threads.

[tkchin_webrtc, 2016-05-16 20:29:19]

lgtm

[danilchap, 2016-05-17 07:32:47]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-05-17 07:32:47]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1968393002/#ps200001 (title:
"rebase including nits")

[commit-bot: I haz the power, 2016-05-17 07:32:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968393002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968393002/200001

[commit-bot: I haz the power, 2016-05-17 08:52:06]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-05-17 08:52:10]

Description was changed from

==========
Propogate network-worker thread split to api


BUG=webrtc:5645
==========

to

==========
Propogate network-worker thread split to api

BUG=webrtc:5645

Committed: https://crrev.com/e9021a3601eff3e33a103ae35fb866554ee28747
Cr-Commit-Position: refs/heads/master@{#12767}
==========

[commit-bot: I haz the power, 2016-05-17 08:52:12]

Patchset 11 (id:??) landed as
https://crrev.com/e9021a3601eff3e33a103ae35fb866554ee28747
Cr-Commit-Position: refs/heads/master@{#12767}