Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1395693002: Add option to print peer connection factory Java stack traces. (Closed)

Created:
5 years, 2 months ago by AlexG
Modified:
5 years, 2 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add option to print peer connection factory Java stack traces. R=wzh@webrtc.org Committed: https://crrev.com/21622a1d19538ca332fe0250ee550d7beeb29802 Cr-Commit-Position: refs/heads/master@{#10204}

Patch Set 1 #

Patch Set 2 : Add native callback API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -3 lines) Patch
M talk/app/webrtc/java/jni/classreferenceholder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 4 chunks +40 lines, -1 line 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnectionFactory.java View 1 3 chunks +38 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
AlexG
PTAL
5 years, 2 months ago (2015-10-07 21:01:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395693002/20001
5 years, 2 months ago (2015-10-07 21:02:16 UTC) #4
wzh
lgtm
5 years, 2 months ago (2015-10-07 21:03:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 21:47:08 UTC) #7
AlexG
Committed patchset #2 (id:20001) manually as 21622a1d19538ca332fe0250ee550d7beeb29802 (presubmit successful).
5 years, 2 months ago (2015-10-07 21:50:26 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 21:50:32 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/21622a1d19538ca332fe0250ee550d7beeb29802
Cr-Commit-Position: refs/heads/master@{#10204}

Powered by Google App Engine
This is Rietveld 408576698