Audio codec usage statistics

webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc

Index: webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc
diff --git a/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc b/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc
index e4da8d7440bc5520342474ca6e9a9360f885c9bc..1133b1b42e0385e8ef94a26d976cee86d02364fb 100644
--- a/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc
+++ b/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc
@@ -96,9 +96,14 @@ AudioEncoder::EncodedInfo AudioEncoderPcm::EncodeImpl(
                                               encoded.data());
                           });
   speech_buffer_.clear();
+  info.encoder_name = GetCodecName();
   return info;
 }
 
+const char* AudioEncoderPcm::GetCodecName() const {
+  return nullptr;
+}

[kwiberg-webrtc, 2016/05/12 13:01:52]

There are only three subclasses. It'll be easier to read if you simply implement
the method for each of them.

+
 void AudioEncoderPcm::Reset() {
   speech_buffer_.clear();
 }
@@ -116,6 +121,10 @@ size_t AudioEncoderPcmA::BytesPerSample() const {
   return 1;
 }
 
+const char* AudioEncoderPcmA::GetCodecName() const {
+  return "g711A";

[hlundin-webrtc, 2016/05/12 12:23:39]

Please, educate me. What is the lifetime of a literal constant like this?

[ossu, 2016/05/12 12:50:14]

FOREVER!
Well, it's static data, so I guess until the binary gets unloaded from memory. I
guess this could happen with dynamic libraries but otherwise it's until the end
of the program.

[aleloi, 2016/05/12 12:52:18]

The same as the lifetime of the whole program according to SO
(http://stackoverflow.com/questions/9970295/life-time-of-string-literal-in-c)

+}
+
 AudioEncoderPcmU::AudioEncoderPcmU(const CodecInst& codec_inst)
     : AudioEncoderPcmU(CreateConfig<AudioEncoderPcmU>(codec_inst)) {}
 
@@ -129,4 +138,8 @@ size_t AudioEncoderPcmU::BytesPerSample() const {
   return 1;
 }
 
+const char* AudioEncoderPcmU::GetCodecName() const {
+  return "g711U";
+}
+
 }  // namespace webrtc