Audio codec usage statistics

webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 78 matching lines @@
   info.encoded_timestamp = first_timestamp_in_buffer_;
   info.payload_type = payload_type_;
   info.encoded_bytes =
       encoded->AppendData(full_frame_samples_ * BytesPerSample(),
                           [&] (rtc::ArrayView<uint8_t> encoded) {
                             return EncodeCall(&speech_buffer_[0],
                                               full_frame_samples_,
                                               encoded.data());
                           });
   speech_buffer_.clear();
+  info.encoder_name = GetCodecName();
   return info;
 }
 
+const char* AudioEncoderPcm::GetCodecName() const {
+  return nullptr;
+}

[kwiberg-webrtc, 2016/05/12 13:01:52]

There are only three subclasses. It'll be easier to read if you simply implement
the method for each of them.

+
 void AudioEncoderPcm::Reset() {
   speech_buffer_.clear();
 }
 
 AudioEncoderPcmA::AudioEncoderPcmA(const CodecInst& codec_inst)
     : AudioEncoderPcmA(CreateConfig<AudioEncoderPcmA>(codec_inst)) {}
 
 size_t AudioEncoderPcmA::EncodeCall(const int16_t* audio,
                                     size_t input_len,
                                     uint8_t* encoded) {
   return WebRtcG711_EncodeA(audio, input_len, encoded);
 }
 
 size_t AudioEncoderPcmA::BytesPerSample() const {
   return 1;
 }
 
+const char* AudioEncoderPcmA::GetCodecName() const {
+  return "g711A";

[hlundin-webrtc, 2016/05/12 12:23:39]

Please, educate me. What is the lifetime of a literal constant like this?

[ossu, 2016/05/12 12:50:14]

FOREVER!
Well, it's static data, so I guess until the binary gets unloaded from memory. I
guess this could happen with dynamic libraries but otherwise it's until the end
of the program.

[aleloi, 2016/05/12 12:52:18]

The same as the lifetime of the whole program according to SO
(http://stackoverflow.com/questions/9970295/life-time-of-string-literal-in-c)

+}
+
 AudioEncoderPcmU::AudioEncoderPcmU(const CodecInst& codec_inst)
     : AudioEncoderPcmU(CreateConfig<AudioEncoderPcmU>(codec_inst)) {}
 
 size_t AudioEncoderPcmU::EncodeCall(const int16_t* audio,
                                     size_t input_len,
                                     uint8_t* encoded) {
   return WebRtcG711_EncodeU(audio, input_len, encoded);
 }
 
 size_t AudioEncoderPcmU::BytesPerSample() const {
   return 1;
 }
 
+const char* AudioEncoderPcmU::GetCodecName() const {
+  return "g711U";
+}
+
 }  // namespace webrtc